Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teacher: relax requirement in smelodesousa/F5/5-brackets #1

Closed
grayswandyr opened this issue Dec 12, 2023 · 3 comments
Closed

Teacher: relax requirement in smelodesousa/F5/5-brackets #1

grayswandyr opened this issue Dec 12, 2023 · 3 comments
Labels
question Further information is requested teacher

Comments

@grayswandyr
Copy link

Brief summary about your teaching context

No response

Question?

Hi, thanks for these exercises. I was thinking the requirement of using a list accumulator for parentheses in smelodesousa/F5/5-brackets is a bit too strong. Using an integer accumulator is enough for this exercise, because there is only one type of symbol to follow. So perhaps it would be better to have only argument for function verify, to let the student devise his/her own implementation approach.

Relevant code

No response

@grayswandyr grayswandyr added question Further information is requested teacher labels Dec 12, 2023
@erikmd
Copy link
Member

erikmd commented Feb 4, 2024

Hi @grayswandyr! Thanks a lot for raising your question!
I Cc @smdsousa (the main author of this learn-ocaml exercise) in case he didn't receive a notification of this thread.

@smdsousa
Copy link

smdsousa commented Feb 4, 2024 via email

@erikmd
Copy link
Member

erikmd commented Feb 4, 2024

Ah OK! Thanks a lot Simão. Indeed, I've just seen (and reviewed) the PR ocaml-sf/learn-ocaml-corpus#40.
I propose we close this question as soon as the PR is integrated.
Cheers, Erik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested teacher
Projects
None yet
Development

No branches or pull requests

3 participants