Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button to move timeline to an object #74

Open
pjotrsavitski opened this issue Sep 28, 2016 · 0 comments
Open

Button to move timeline to an object #74

pjotrsavitski opened this issue Sep 28, 2016 · 0 comments
Labels

Comments

@pjotrsavitski
Copy link
Member

Activity stream item could have a button that would move the timeline to show that item (just moving to the start of it should do).

it could probably be beneficial to hide that button from already removed objects.

pjotrsavitski added a commit to learning-layers/timeliner-client that referenced this issue Oct 4, 2016
Refactored finding items by id or index in storge by item, added central
methods to be used everywhere. Also added the method to scroll timeline
to the item, if exists (used by stream).
pjotrsavitski added a commit to learning-layers/timeliner-client that referenced this issue Oct 4, 2016
Added initial implementation of the feature. As of the moment, it could
be creating too many watchers and has other issues (like inability to
really detect if item frerenced from activity still exists). These
should be resolved later, if that is proven to be needed.
pjotrsavitski added a commit to learning-layers/timeliner-client that referenced this issue Oct 4, 2016
Changed the check to only be applied once, the currrent code will is not
really checking anything taht could change in the future. It is better
to keep unneeded watchers away.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant