From 621f92b4cb98f0f3983a307a9323084e74401c6b Mon Sep 17 00:00:00 2001 From: Rafal Paradowski Date: Sat, 16 Nov 2024 18:04:22 +0100 Subject: [PATCH 1/3] Use notify_team_new_comment from .github repo --- .github/workflows/notify_team_new_comment.yml | 28 +------------------ 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/.github/workflows/notify_team_new_comment.yml b/.github/workflows/notify_team_new_comment.yml index 6f6004ea398..c4633d697a7 100644 --- a/.github/workflows/notify_team_new_comment.yml +++ b/.github/workflows/notify_team_new_comment.yml @@ -6,30 +6,4 @@ on: jobs: contributor_issue_comment: - name: Contributor issue comment - - if: >- - ${{ - !github.event.issue.pull_request && - github.event.comment.author_association != 'MEMBER' && - github.event.comment.author_association != 'OWNER' - }} - - runs-on: ubuntu-latest - steps: - - name: Escape title double quotes - id: escape_title - env: - ISSUE_TITLE: ${{ github.event.issue.title }} - run: echo "ISSUE_TITLE=${ISSUE_TITLE//\"/\\\"}" >> "$GITHUB_OUTPUT" - - - name: Send message to Slack channel - env: - SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} - SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK - uses: slackapi/slack-github-action@v1.27.0 - with: - payload: | - { - "text": "*[Kolibri] New comment on issue: <${{ github.event.issue.html_url }}#issuecomment-${{ github.event.comment.id }}|${{ steps.escape_title.outputs.ISSUE_TITLE }} by ${{ github.event.comment.user.login }}>*" - } + uses: rparadowski/.github/.github/workflows/notify_team_new_comment.yml@12567_issue From 9094f1682ca80b969aecc265c0c8328e9976e3d4 Mon Sep 17 00:00:00 2001 From: Rafal Paradowski Date: Tue, 19 Nov 2024 12:18:10 +0100 Subject: [PATCH 2/3] Pass secret --- .github/workflows/notify_team_new_comment.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/notify_team_new_comment.yml b/.github/workflows/notify_team_new_comment.yml index c4633d697a7..77b56d5f53c 100644 --- a/.github/workflows/notify_team_new_comment.yml +++ b/.github/workflows/notify_team_new_comment.yml @@ -7,3 +7,5 @@ on: jobs: contributor_issue_comment: uses: rparadowski/.github/.github/workflows/notify_team_new_comment.yml@12567_issue + secrets: + SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} From cd9a6310eddc2e48f5eb739981cee531468c54d0 Mon Sep 17 00:00:00 2001 From: Rafal Paradowski Date: Tue, 3 Dec 2024 12:41:46 +0100 Subject: [PATCH 3/3] Use official repo --- .github/workflows/notify_team_new_comment.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/notify_team_new_comment.yml b/.github/workflows/notify_team_new_comment.yml index 77b56d5f53c..07a837e4d39 100644 --- a/.github/workflows/notify_team_new_comment.yml +++ b/.github/workflows/notify_team_new_comment.yml @@ -6,6 +6,6 @@ on: jobs: contributor_issue_comment: - uses: rparadowski/.github/.github/workflows/notify_team_new_comment.yml@12567_issue + uses: learningequality/.github/.github/workflows/notify_team_new_comment.yml@main secrets: SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}