-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic layout for displaying "resources currently in lesson" #12845
Open
AllanOXDi
wants to merge
6
commits into
learningequality:develop
Choose a base branch
from
AllanOXDi:basic-layout-for-lesson-resources
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Basic layout for displaying "resources currently in lesson" #12845
AllanOXDi
wants to merge
6
commits into
learningequality:develop
from
AllanOXDi:basic-layout-for-lesson-resources
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Coach
Re: Coach App (lessons, quizzes, groups, reports, etc.)
DEV: frontend
labels
Nov 14, 2024
AllanOXDi
changed the title
WIP- don't even bother at it.
WIP- don't even bother looking at it.
Nov 14, 2024
AllanOXDi
force-pushed
the
basic-layout-for-lesson-resources
branch
from
November 21, 2024 19:37
64c274c
to
e18471f
Compare
Build Artifacts
|
AllanOXDi
force-pushed
the
basic-layout-for-lesson-resources
branch
from
November 22, 2024 18:03
38f90a6
to
4fa945b
Compare
AllanOXDi
changed the title
WIP- don't even bother looking at it.
Basic layout display for "resources currently in lesson"
Nov 22, 2024
hey @nucleogenesis this is the first part of the layout for displaying "resources currently in lesson. I have left few requirements out will get back to it on monday |
AllanOXDi
changed the title
Basic layout display for "resources currently in lesson"
Basic layout for displaying "resources currently in lesson"
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the "shopping cart" preview functionality as part of aligning the lesson management workflow with the side panel management
References
#12787
Reviewer guidance
For now test if
It displays an array of contentnodes, all of which are resources (no folders)
In the bottom bar a link should be displayed whenever the array length is > 0
On "select" it opens "shopping cart"
The header should display the number of items in the selection array
The lesson name is rendered in
The "back" arrow "minimizes" the shopping cart view. The "X" closes the side panel. no validation for closing is required
If each resource in the array is displayed as an item
If each item should have a content node icon
Not working.
Displaying the file size for each item in the list.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)