Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic layout for displaying "resources currently in lesson" #12845

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

AllanOXDi
Copy link
Member

@AllanOXDi AllanOXDi commented Nov 14, 2024

Summary

This PR implements the "shopping cart" preview functionality as part of aligning the lesson management workflow with the side panel management

References

#12787

Reviewer guidance

For now test if

  • It displays an array of contentnodes, all of which are resources (no folders)

  • In the bottom bar a link should be displayed whenever the array length is > 0

  • On "select" it opens "shopping cart"

  • The header should display the number of items in the selection array

  • The lesson name is rendered in

  • The "back" arrow "minimizes" the shopping cart view. The "X" closes the side panel. no validation for closing is required

  • If each resource in the array is displayed as an item

  • If each item should have a content node icon

Not working.
Displaying the file size for each item in the list.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Nov 14, 2024
@AllanOXDi AllanOXDi changed the title WIP- don't even bother at it. WIP- don't even bother looking at it. Nov 14, 2024
@AllanOXDi AllanOXDi force-pushed the basic-layout-for-lesson-resources branch from 64c274c to e18471f Compare November 21, 2024 19:37
@AllanOXDi AllanOXDi force-pushed the basic-layout-for-lesson-resources branch from 38f90a6 to 4fa945b Compare November 22, 2024 18:03
@AllanOXDi AllanOXDi changed the title WIP- don't even bother looking at it. Basic layout display for "resources currently in lesson" Nov 22, 2024
@AllanOXDi AllanOXDi marked this pull request as ready for review November 22, 2024 19:02
@AllanOXDi
Copy link
Member Author

AllanOXDi commented Nov 22, 2024

hey @nucleogenesis this is the first part of the layout for displaying "resources currently in lesson. I have left few requirements out will get back to it on monday

@AllanOXDi AllanOXDi changed the title Basic layout display for "resources currently in lesson" Basic layout for displaying "resources currently in lesson" Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant