Fix colors of list items in quiz preview #12920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and remove hardcoded colors in favor of theme tokens. Fixes learningequality#12425
github-actions
bot
added
APP: Coach
Build Artifacts
|
pcenov
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Hi @nucleogenesis - I confirm that the colors are fixed now! Did someone change something about the rendering of the Perseus exercises - some of them are not displayed at all?
2024-12-10_17-28-36.mp4
|
@pcenov this appears to be a regression caused by my PR here: #12851 Although - it does seem to be blocking some things that should not be being loaded - either way, we want this to render, so if you could file this issue as a follow up, and specify precisely which exercises are producing these errors, it would be much appreciated! (I will happily take a KOLIBRI_HOME folder attachment for easy replication!) |
rtibbles
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
git cherry-picks the commit 928a09b by @MisRob which previously fixed the issue #12425 - seems likely it was lost in the shuffle when preview was moved to it's own page.2024-12-09.14-35-04.mp4
References
Fixes #12425
Reviewer guidance
Does this re-fix the issue as expected?