Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign desktop wallet on windows #1243

Open
kyranjamie opened this issue Oct 16, 2023 · 0 comments
Open

Sign desktop wallet on windows #1243

kyranjamie opened this issue Oct 16, 2023 · 0 comments
Labels
Bug 🐛 Functionality broken P1 Bug 🚨 Critical functionality broken for many customers, with no clear workarounds

Comments

@kyranjamie
Copy link
Collaborator

Now that our cert has expired, the build for Windows no longer works

• signing         file=release\win-unpacked\Leather.exe certificateFile=C:\Users\RUNNER~1\AppData\Local\Temp\t-1kWdY7\***.p12
  ⨯ Exit code: 1. Command failed: C:\Users\runneradmin\AppData\Local\electron-builder\Cache\winCodeSign\winCodeSign-2.6.***\windows-1***\x64\signtool.exe sign /t http://timestamp.digicert.com/ /f C:\Users\RUNNER~1\AppData\Local\Temp\t-1kWdY7\***.p12 /d Leather /du https://leather.io/ /p 3cf3bfa9a32***aafaa6df753***8e5ac3bd6d84bc9be1823259f69f***18c59439d17 (sha256 hash) /debug D:\a\desktop\desktop\release\win-unpacked\Leather.exe
SignTool Error: No certificates were found that met all the given criteria.


The following certificates were considered:
    Issued to: Hiro Systems PBC

    Issued by: DigiCert Trusted G4 Code Signing RSA4***96 SHA384 2***21 CA1

    Expires:   Thu Oct 12 23:59:59 2***23

    SHA1 hash: 17FFE4E4F9ADAF6DECEB2F62B3435B9D98484***45


After EKU filter, 1 certs were left.
After expiry filter, *** certs were left.
After Private Key filter, *** certs were left.

SignTool Error: No certificates were found that met all the given criteria.
  stackTrace=
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  Error: Exit code: 1. Command failed: C:\Users\runneradmin\AppData\Local\electron-builder\Cache\winCodeSign\winCodeSign-2.6.***\windows-1***\x64\signtool.exe sign /t http://timestamp.digicert.com/ /f C:\Users\RUNNER~1\AppData\Local\Temp\t-1kWdY7\***.p12 /d Leather /du https://leather.io/ /p 3cf3bfa9a32***aafaa6df753***8e5ac3bd6d84bc9be1823259f69f***18c59439d17 (sha256 hash) /debug D:\a\desktop\desktop\release\win-unpacked\Leather.exe
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  SignTool Error: No certificates were found that met all the given criteria.
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  The following certificates were considered:
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      Issued to: Hiro Systems PBC

                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      Issued by: DigiCert Trusted G4 Code Signing RSA4***96 SHA384 2***21 CA1

                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      Expires:   Thu Oct 12 23:59:59 2***23

                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      SHA1 hash: 17FFE4E4F9ADAF6DECEB2F62B3435B9D98484***45

                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  After EKU filter, 1 certs were left.
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  After expiry filter, *** certs were left.
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  After Private Key filter, *** certs were left.
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  SignTool Error: No certificates were found that met all the given criteria.
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      at D:\a\desktop\desktop\node_modules\builder-util\src\util.ts:129:16
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      at ChildProcess.exithandler (node:child_process:43***:5)
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      at ChildProcess.emit (node:events:517:28)
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      at maybeClose (node:internal/child_process:1***98:16)
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      at Process.ChildProcess._handle.onexit (node:internal/child_process:3***3:5)
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  From previous event:
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      at processImmediate (node:internal/timers:476:21)
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  From previous event:
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      at WinPackager.signApp (D:\a\desktop\desktop\node_modules\app-builder-lib\src\winPackager.ts:357:27)
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      at WinPackager.doSignAfterPack (D:\a\desktop\desktop\node_modules\app-builder-lib\src\platformPackager.ts:27***:16)
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      at WinPackager.doPack (D:\a\desktop\desktop\node_modules\app-builder-lib\src\platformPackager.ts:255:7)
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      at WinPackager.pack (D:\a\desktop\desktop\node_modules\app-builder-lib\src\platformPackager.ts:115:5)
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      at Packager.doBuild (D:\a\desktop\desktop\node_modules\app-builder-lib\src\packager.ts:434:9)
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      at executeFinally (D:\a\desktop\desktop\node_modules\builder-util\src\promise.ts:12:14)
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      at Packager._build (D:\a\desktop\desktop\node_modules\app-builder-lib\src\packager.ts:369:31)
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      at Packager.build (D:\a\desktop\desktop\node_modules\app-builder-lib\src\packager.ts:333:12)
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      at executeFinally (D:\a\desktop\desktop\node_modules\builder-util\src\promise.ts:12:14)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.
@kyranjamie kyranjamie added Bug 🐛 Functionality broken P1 Bug 🚨 Critical functionality broken for many customers, with no clear workarounds labels Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Functionality broken P1 Bug 🚨 Critical functionality broken for many customers, with no clear workarounds
Projects
None yet
Development

No branches or pull requests

1 participant