Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Makefile hierarchy for extensions #1460

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anlsh
Copy link
Contributor

@anlsh anlsh commented Jul 27, 2024

This is half-baked, admittedly. extensions/Makefile should be looping over its subdirectories somehow to avoid the big hardcoded string, and "make ext" only works on linux.

Also, the hardcoded paths in the Makefile are not great, but I'd like to change this before merge. Ideally instead of having a lib/linux and lib/macosx both with shared objects (and in-tree), we'd just have a lib/ (or build/, which I think is a bit better) which "make ext" can just fill with the right .so

We'd have to update the github releases to distribute (and generate) independent osx and linux packages, but that seems like a fair price for eliminating the blobs from the tree

Also: I'm not sure where the relevant docs (so that I can specify that that libvterm 3.3+ is required) are: seems the sources for https://lem-project.github.io/installation/ncurses/linux/ aren't actually in this repo?

This is half-baked, admittedly. extensions/Makefile should be looping
over its subdirectories somehow to avoid the big hardcoded string, and
"make ext" only works on linux.

Also, the hardcoded paths in the Makefile are not great, but I'd like
to change this before merge. Ideally instead of having a lib/linux and
lib/macosx both with shared objects (and in-tree), we'd just have a
lib/ (or build/, which I think is a bit better) which "make ext" can
just fill with the right .so

We'd have to update the github releases to distribute (and generate)
independent osx and linux packages, but that seems like a fair price for
eliminating the blobs from the tree

Also: I'm not sure where the relevant docs (so that I can specify that
that libvterm 3.3+ is required) are: seems the sources for
https://lem-project.github.io/installation/ncurses/linux/ aren't
actually in this repo?
@cxxxr
Copy link
Member

cxxxr commented Jul 28, 2024

The document repository is here
https://github.com/lem-project/lem-project.github.io

by the way, I don't think there has been agreement on not including shared objects in the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants