Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add handheld dynamic lights #8

Open
wezap opened this issue Apr 21, 2023 · 3 comments
Open

Please add handheld dynamic lights #8

wezap opened this issue Apr 21, 2023 · 3 comments

Comments

@wezap
Copy link

wezap commented Apr 21, 2023

Is good because it's not laggy like lambdynamiclights which is the only way to get dynamic lights with this shader on iris right now.

@leo60228
Copy link
Owner

leo60228 commented May 1, 2023

I don't see any reason LambDynamicLights would be slower than dynamic lights implemented in a shader. I use LambDynamicLights with this shader myself and don't have performance issues, maybe it's a hardware-specific bug you should report to the dev?

I'm not necessarily ruling this out, but the primary purpose of this shader is just anti-aliasing, and I don't really want to spend a ton of effort on adding this when there's already a compatible solution.

@wezap
Copy link
Author

wezap commented Sep 3, 2023

This is amazing. Relevant because lambdynamiclights doesn't work now with the latest version of sodium. Thank you.

@Felix14-v2
Copy link

I don't see any reason LambDynamicLights would be slower than dynamic lights implemented in a shader

Well, on some systems LDL performs extremely slow. You can check the example here: Additive#36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants