Fixes discussions import/export

lepidus · Apr 24, 2024 · 577d7ce · 577d7ce
1 parent 87a54ac
commit 577d7ce
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 8 deletions.
diff --git a/filter/export/ExtendedArticleNativeXmlFilter.inc.php b/filter/export/ExtendedArticleNativeXmlFilter.inc.php
@@ -117,14 +117,19 @@ public function addQueries($doc, $parentNode, $submission, $stageId)
         $queryDAO = DAORegistry::getDAO('QueryDAO');
 
         $queries = $queryDAO->getByAssoc(ASSOC_TYPE_SUBMISSION, $submission->getId(), $stageId);
-
         $queriesNode = $doc->createElementNS($deployment->getNamespace(), 'queries');
         while ($query = $queries->next()) {
+            $participantIds = $queryDAO->getParticipantIds($query->getId());
+
+            if (empty($participantIds)) {
+                continue;
+            }
+
             $queryNode = $doc->createElementNS($deployment->getNamespace(), 'query');
             $queryNode->setAttribute('seq', $query->getData('sequence'));
             $queryNode->setAttribute('closed', (int) $query->getData('closed'));
 
-            $queryNode->appendChild($this->createQueryParticipantsNode($doc, $deployment, $query));
+            $queryNode->appendChild($this->createQueryParticipantsNode($doc, $deployment, $participantIds));
             $queryNode->appendChild($this->createQueryRepliesNode($doc, $deployment, $submission, $query));
 
             $queriesNode->appendChild($queryNode);
@@ -135,12 +140,10 @@ public function addQueries($doc, $parentNode, $submission, $stageId)
         }
     }
 
-    private function createQueryParticipantsNode($doc, $deployment, $query)
+    private function createQueryParticipantsNode($doc, $deployment, $participantIds)
     {
-        $queryDAO = DAORegistry::getDAO('QueryDAO');
         $userDAO = DAORegistry::getDAO('UserDAO');
         $participantsNode = $doc->createElementNS($deployment->getNamespace(), 'participants');
-        $participantIds = $queryDAO->getParticipantIds($query->getId());
 
         foreach ($participantIds as $participantId) {
             $participant = $userDAO->getById($participantId);
@@ -162,6 +165,9 @@ private function createQueryRepliesNode($doc, $deployment, $submission, $query)
 
         while ($note = $replies->next()) {
             $user = $note->getUser();
+            if (!$user) {
+                continue;
+            }
             $noteNode = $doc->createElementNS($deployment->getNamespace(), 'note');
             $noteNode->setAttribute('user_email', htmlspecialchars($user->getEmail(), ENT_COMPAT, 'UTF-8'));
             $noteNode->setAttribute('date_modified', $note->getDateModified());

diff --git a/filter/import/NativeXmlExtendedArticleFilter.inc.php b/filter/import/NativeXmlExtendedArticleFilter.inc.php
@@ -209,8 +209,8 @@ public function parseQuery($node, $submission, $stageId)
 
             $deployment->setNote($note);
             $noteFilesNodes = $noteNode->getElementsByTagNameNS($deployment->getNamespace(), 'workflow_file');
-            for ($i = 0; $i < $noteFilesNodes->count(); $i++) {
-                $noteNode = $noteFilesNodes->item($i);
+            for ($fileIndex = 0; $fileIndex < $noteFilesNodes->count(); $fileIndex++) {
+                $noteNode = $noteFilesNodes->item($fileIndex);
                 $this->parseArticleFile($noteNode);
             }
         }

diff --git a/fullJournal.xsd b/fullJournal.xsd
@@ -394,7 +394,7 @@
 	<element name="replies">
 		<complexType>
 			<sequence>
-				<element ref="pkp:note" minOccurs="1" maxOccurs="unbounded" />
+				<element ref="pkp:note" minOccurs="0" maxOccurs="unbounded" />
 			</sequence>
 		</complexType>
 	</element>