[17.0][MIG] account_cutoff_base: Migration to 17.0 #1

lethuthao2403 · 2023-11-27T08:02:37Z

No description provided.

Use assert Remove .keys() No space before colon PEP8/Flake8 : getting closer to compliancy

….get('type', '-')

…de domains) On account.account, type must be <> 'view' and <> 'closed'

…a single warning left ! Add translation template files.

…rted

The signature of existing methods is preserved.

Extract a new module account_invoice_start_end_dates from account_cutoff_prepaid

Use triple double quotes for docstring Replace <openerp> by <odoo> in XML Remove <data> tags in XML Remove POT files

Currently translated at 100,0% (73 of 73 strings) Translation: account-closing-11.0/account-closing-11.0-account_cutoff_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-11-0/account-closing-11-0-account_cutoff_base/de/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-closing-16.0/account-closing-16.0-account_cutoff_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_cutoff_base/

Co-authored-by: Alexis de Lattre <[email protected]>

dzungtran89 · 2023-11-29T05:17:34Z

account_cutoff_base/migrations/16.0.1.0.0/pre-migration.py

@@ -0,0 +1,21 @@
+# Copyright 2023 Akretion France (http://www.akretion.com/)


@thaolt99 This mig script is no longer needed

dzungtran89 · 2023-11-29T05:19:21Z

account_cutoff_base/readme/CREDITS.md

@@ -0,0 +1,2 @@
+The migration of this module from 16.0 to 17.0 was financially supported
+by Camptocamp


Suggested change

by Camptocamp

by Camptocamp.

dzungtran89 · 2023-11-29T05:19:55Z

account_cutoff_base/readme/CONTRIBUTORS.md

+
+- [Trobz](https://trobz.com):  
+  - Dzung Tran \<<[email protected]>\>
+  - Thao Le <[email protected]>


Suggested change

- Thao Le <[email protected]>

- Thao Le \<<[email protected]>\>

Then regenerating the readme file

@dzungtran89 the PR has been updated! Thank you.

dzungtran89

lgtm overall, minor changes needed

dzungtran89 · 2023-11-29T05:39:29Z

@thaolt99 the readme file is not updated yet

lethuthao2403 · 2023-11-29T06:35:09Z

@dzungtran89 the PR has been updated! Thank you.

dzungtran89

thx, lgtm

nguyenminhchien · 2023-11-30T05:02:27Z

account_cutoff_base/models/account_cutoff.py

def name_get(self): you should now override _compute_display_name instead, adding the possible new fields in the depends of the method
Check https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0 for more information

nguyenminhchien · 2023-11-30T05:05:07Z

account_cutoff_base/views/account_cutoff_line.xml

replace invisible by column_invisible on tree view:

<field name="parent_id" invisible="not context.get('account_cutoff_line_main_view', False)" />

<field name="currency_id" invisible="1" />
<field name="company_currency_id" invisible="1" />

nguyenminhchien · 2023-11-30T05:07:49Z

account_cutoff_base/views/account_cutoff_tax_line.xml

+            <tree>
+                <field
+                    name="parent_id"
+                    invisible="not context.get('account_cutoff_tax_line_main_view', False)"


Suggested change

invisible="not context.get('account_cutoff_tax_line_main_view', False)"

column_invisible="not context.get('account_cutoff_tax_line_main_view', False)"

nguyenminhchien · 2023-11-30T05:08:04Z

account_cutoff_base/views/account_cutoff_tax_line.xml

+                />
+                <field name="base" />
+                <field name="amount" />
+                <field name="currency_id" invisible="1" />


Suggested change

<field name="currency_id" invisible="1" />

<field name="currency_id" column_invisible="1" />

nguyenminhchien · 2023-11-30T05:08:10Z

account_cutoff_base/views/account_cutoff_tax_line.xml

+                <field name="amount" />
+                <field name="currency_id" invisible="1" />
+                <field name="cutoff_amount" />
+                <field name="company_currency_id" invisible="1" />


Suggested change

<field name="company_currency_id" invisible="1" />

<field name="company_currency_id" column_invisible="1" />

nguyenminhchien · 2023-11-30T05:08:19Z

account_cutoff_base/views/account_cutoff_tax_line.xml

+                <field name="currency_id" invisible="1" />
+                <field name="cutoff_amount" />
+                <field name="company_currency_id" invisible="1" />
+                <field name="sequence" invisible="1" />


Suggested change

<field name="sequence" invisible="1" />

<field name="sequence" column_invisible="1" />

nguyenminhchien · 2023-11-30T05:08:39Z

account_cutoff_base/views/account_cutoff_mapping.xml

+                    options="{'no_create': True}"
+                    optional="show"
+                />
+                <field name="company_id" invisible="1" />


Suggested change

<field name="company_id" invisible="1" />

<field name="company_id" column_invisible="1" />

nguyenminhchien · 2023-11-30T05:09:37Z

account_cutoff_base/views/account_cutoff.xml

+                <field
+                    name="cutoff_type"
+                    readonly="state == 'done'"
+                    invisible="context.get('default_cutoff_type')"


Suggested change

invisible="context.get('default_cutoff_type')"

column_invisible="context.get('default_cutoff_type')"

nguyenminhchien · 2023-11-30T05:09:48Z

account_cutoff_base/views/account_cutoff.xml

+                <field name="cutoff_date" decoration-bf="1" />
+                <field name="move_ref" optional="hide" />
+                <field name="total_cutoff_amount" />
+                <field name="company_currency_id" invisible="1" />


Suggested change

<field name="company_currency_id" invisible="1" />

<field name="company_currency_id" column_invisible="1" />

lethuthao2403 · 2023-11-30T05:27:11Z

@nguyenminhchien the PR has been updated! Thanks.

dzungtran89 · 2023-11-30T06:40:56Z

account_cutoff_base/models/account_cutoff.py

+            name = type2label.get(rec.cutoff_type, "")
+            if rec.cutoff_date:
+                name = f"({name}, {format_date(self.env, rec.cutoff_date)})"
+            rec.display_name = rec.name or f"#{rec.id}"


Suggested change

rec.display_name = rec.name or f"#{rec.id}"

rec.display_name = name

Alexis de Lattre and others added 30 commits November 27, 2023 13:59

Initial check-in of my cut-off modules

f8052c1

Coding style enhancements (osv.Model -> orm.Model, from . import xxx)

f06c017

Add _prepare functions to allow to inherit before create

8b0c5d0

Use assert Remove .keys() No space before colon PEP8/Flake8 : getting closer to compliancy

Forgot to move some code to the new _prepare function.

625f06f

Remove the unnecessary "and True or False" after 'xxx' not in context…

1c0af64

….get('type', '-')

Reduce flake8 warnings (cut lines and comments, space after coma insi…

b3473e8

…de domains) On account.account, type must be <> 'view' and <> 'closed'

My christmas present to the PEP8 fundamentalists : there is not even …

d99ac4b

…a single warning left ! Add translation template files.

all modules unported to odoo 8.0

a5e4c85

[MIG] move account_cutoff_base and account_cutoff_prepaid out of unpo…

14e1f71

…rted

[MIG] account_cutoff: set installable=True

6d11b6c

[MIG] account_cutoff_prepaid 8.0

263ca8d

[IMP] account_cutoff_prepaid: add hooks

d921282

The signature of existing methods is preserved.

[ADD][account_cutoff_base] Add multi-company record rule

51b1e20

Add missing default oca icons

c38a6fb

[UPD] prefix versions with 8.0

fcb8446

[MIG] Make modules uninstallable

7eca2db

[MIG] Rename manifest files

20e340c

Port account_cutoff_base and account_cutoff_prepaid to Odoo v9

96e2f07

Extract a new module account_invoice_start_end_dates from account_cutoff_prepaid

Add some hooks that are in 8.0

6cbe07f

Take into account the remarks of Pedro:

b00bbe6

Use triple double quotes for docstring Replace <openerp> by <odoo> in XML Remove <data> tags in XML Remove POT files

Migration of account_cutoff modules to 10.0

fa0603f

[FIX] Bad attributes on m2m fields.

50856e5

[IMP] Add some tests to improve the code coverage

a787338

[MIG] account_cutoff_base: Migration to 11.0

4696fea

[UPD] Update account_cutoff_base.pot

141912f

[MIG] account_cutoff_base: Migration to 12.0

62c536e

[12.0-mig-account] fixing review comments

2ec6a88

[UPD] Update account_cutoff_base.pot

409394d

[FIX] remove titles from readme fragments

36fbd41

jbaudoux and others added 5 commits November 27, 2023 13:59

[FIX] account_cutoff_base: tax in view

58d9ed8

[UPD] Update account_cutoff_base.pot

dfb45bb

[BOT] post-merge updates

ef03bc1

[TRN] remove fr_FR.po

4e441b1

Co-authored-by: Alexis de Lattre <[email protected]>

lethuthao2403 force-pushed the 17.0-mig-account_cutoff_base branch 4 times, most recently from 6234123 to 9a31f79 Compare November 28, 2023 03:50

dzungtran89 reviewed Nov 29, 2023

View reviewed changes

dzungtran89 approved these changes Nov 29, 2023

View reviewed changes

lethuthao2403 force-pushed the 17.0-mig-account_cutoff_base branch from 9a31f79 to 650c4cf Compare November 29, 2023 05:28

lethuthao2403 requested a review from dzungtran89 November 29, 2023 05:28

lethuthao2403 force-pushed the 17.0-mig-account_cutoff_base branch from 650c4cf to e6f8137 Compare November 29, 2023 06:30

dzungtran89 approved these changes Nov 29, 2023

View reviewed changes

[IMP] account_cutoff_base: pre-commit auto fixes

a86eb2d

lethuthao2403 force-pushed the 17.0-mig-account_cutoff_base branch from e6f8137 to 3e7158a Compare November 30, 2023 03:47

nguyenminhchien suggested changes Nov 30, 2023

View reviewed changes

lethuthao2403 force-pushed the 17.0-mig-account_cutoff_base branch from 3e7158a to cef6c3d Compare November 30, 2023 05:26

dzungtran89 reviewed Nov 30, 2023

View reviewed changes

lethuthao2403 force-pushed the 17.0-mig-account_cutoff_base branch from cef6c3d to fc13845 Compare November 30, 2023 07:05

nguyenminhchien approved these changes Nov 30, 2023

View reviewed changes

lethuthao2403 force-pushed the 17.0-mig-account_cutoff_base branch from fc13845 to ea6a5e3 Compare December 5, 2023 08:15

[MIG] account_cutoff_base: Migration to 17.0

1811361

lethuthao2403 force-pushed the 17.0-mig-account_cutoff_base branch from ea6a5e3 to 1811361 Compare December 5, 2023 08:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] account_cutoff_base: Migration to 17.0 #1

[17.0][MIG] account_cutoff_base: Migration to 17.0 #1

lethuthao2403 commented Nov 27, 2023

dzungtran89 Nov 29, 2023

dzungtran89 Nov 29, 2023

dzungtran89 Nov 29, 2023

lethuthao2403 Nov 29, 2023

dzungtran89 left a comment

dzungtran89 commented Nov 29, 2023 •

edited

Loading

lethuthao2403 commented Nov 29, 2023

dzungtran89 left a comment

nguyenminhchien Nov 30, 2023

nguyenminhchien Nov 30, 2023

nguyenminhchien Nov 30, 2023

nguyenminhchien Nov 30, 2023

nguyenminhchien Nov 30, 2023

nguyenminhchien Nov 30, 2023

nguyenminhchien Nov 30, 2023

nguyenminhchien Nov 30, 2023

nguyenminhchien Nov 30, 2023

lethuthao2403 commented Nov 30, 2023

dzungtran89 Nov 30, 2023

		@@ -0,0 +1,21 @@
		# Copyright 2023 Akretion France (http://www.akretion.com/)

		@@ -0,0 +1,2 @@
		The migration of this module from 16.0 to 17.0 was financially supported
		by Camptocamp

	- Thao Le <[email protected]>
	- Thao Le \<<[email protected]>\>

	invisible="not context.get('account_cutoff_tax_line_main_view', False)"
	column_invisible="not context.get('account_cutoff_tax_line_main_view', False)"

	<field name="currency_id" invisible="1" />
	<field name="currency_id" column_invisible="1" />

	<field name="company_currency_id" invisible="1" />
	<field name="company_currency_id" column_invisible="1" />

	<field name="sequence" invisible="1" />
	<field name="sequence" column_invisible="1" />

	<field name="company_id" invisible="1" />
	<field name="company_id" column_invisible="1" />

	invisible="context.get('default_cutoff_type')"
	column_invisible="context.get('default_cutoff_type')"

	rec.display_name = rec.name or f"#{rec.id}"
	rec.display_name = name

[17.0][MIG] account_cutoff_base: Migration to 17.0 #1

Are you sure you want to change the base?

[17.0][MIG] account_cutoff_base: Migration to 17.0 #1

Conversation

lethuthao2403 commented Nov 27, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dzungtran89 left a comment

Choose a reason for hiding this comment

dzungtran89 commented Nov 29, 2023 • edited Loading

lethuthao2403 commented Nov 29, 2023

dzungtran89 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lethuthao2403 commented Nov 30, 2023

Choose a reason for hiding this comment

dzungtran89 commented Nov 29, 2023 •

edited

Loading