Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wfe: propagate cancellations #7761

Closed
jsha opened this issue Oct 22, 2024 · 1 comment · Fixed by #7778
Closed

wfe: propagate cancellations #7761

jsha opened this issue Oct 22, 2024 · 1 comment · Fixed by #7778
Assignees

Comments

@jsha
Copy link
Contributor

jsha commented Oct 22, 2024

In #5459 and #6608 we prevented propagation of cancellation from clients to SA / WFE. This was an attempt to solve a performance issue we found when upgrading go-sql-driver/mysql: #5437. That was speculative, however. We never confirmed that cancellations were causing connection churn. And we now have a better theory as to what caused the problem: #7556.

Now we have been having some performance problems that appear to be related to requests piling up and new requests timing out before any work gets done. This is the sort of situation that cancellation helps to solve.

We should (behind a feature flag) re-enable propagation of cancellations.

@aarongable aarongable added this to the Sprint 2024-10-29 milestone Oct 29, 2024
@aarongable
Copy link
Contributor

Fixed by #7778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants