Moved mnedc logic to discoverymgr, which fixes #178 (#180)

Signed-off-by: ayush.kumar <[email protected]>
- Since MNEDC responsibility is similar to the Discovery Manager, the mnedcmgr package has now been moved inside discoverymgr package and renamed to mnedc.

GoMain/src/main/main.go

@@ -21,15 +21,15 @@ package main
 import (
 	"errors"
 	"log"
-	"strings"
 	"os"
+	"strings"
 
 	"common/logmgr"
 	"common/sigmgr"
 
 	configuremgr "controller/configuremgr/container"
 	"controller/discoverymgr"
-	"controller/mnedcmgr"
+	mnedcmgr "controller/discoverymgr/mnedc"
 	"controller/scoringmgr"
 	"controller/securemgr/authenticator"
 	"controller/securemgr/authorizer"
@@ -72,10 +72,10 @@ const (
 	passPhraseJWTPath      = edgeDir + "/data/jwt"
 	rbacRulePath           = edgeDir + "/data/rbac"
 
-	cipherKeyFilePath      = edgeDir + "/user/orchestration_userID.txt"
-	deviceIDFilePath       = edgeDir + "/device/orchestration_deviceID.txt"
-	dataStorageFilePath    = edgeDir + "/datastorage/configuration.toml"
-	mnedcServerConfig      = edgeDir + "/mnedc/client.config"
+	cipherKeyFilePath   = edgeDir + "/user/orchestration_userID.txt"
+	deviceIDFilePath    = edgeDir + "/device/orchestration_deviceID.txt"
+	dataStorageFilePath = edgeDir + "/datastorage/configuration.toml"
+	mnedcServerConfig   = edgeDir + "/mnedc/client.config"
 )
 
 var (
@@ -104,8 +104,8 @@ func orchestrationInit() error {
 	mnedc := os.Getenv("MNEDC")
 
 	isSecured := false
-	if len(secure)>0 {
-		if strings.Compare(strings.ToLower(secure), "true")==0 {
+	if len(secure) > 0 {
+		if strings.Compare(strings.ToLower(secure), "true") == 0 {
 			log.Println("Orchestration init with secure option")
 			isSecured = true
 		}
@@ -130,6 +130,7 @@ func orchestrationInit() error {
 
 	servicemgr.GetInstance().SetClient(restIns)
 	discoverymgr.GetInstance().SetClient(restIns)
+	mnedcmgr.GetClientInstance().SetClient(restIns)
 
 	builder := orchestrationapi.OrchestrationBuilder{}
 	builder.SetWatcher(configuremgr.GetInstance(configPath))
@@ -182,28 +183,28 @@ func orchestrationInit() error {
 
 	restEdgeRouter.Start()
 
-	if _, err := os.Stat(dataStorageFilePath); err==nil {
+	if _, err := os.Stat(dataStorageFilePath); err == nil {
 		sd := storagedriver.StorageDriver{}
 		go startup.Bootstrap(dataStorageService, device.Version, &sd)
 	}
 
 	log.Println(logPrefix, "orchestration init done")
 
 	if len(mnedc) > 0 {
-                if strings.Compare(strings.ToLower(mnedc), "server") == 0 {
-                        if isSecured {
-                                mnedcmgr.GetServerInstance().SetCipher(dummy.GetCipher(cipherKeyFilePath))
-                                mnedcmgr.GetServerInstance().SetCertificateFilePath(certificateFilePath)
-                        } else {
-                                mnedcmgr.GetServerInstance().SetCipher(sha256.GetCipher(cipherKeyFilePath))
-                        }
-                        go mnedcmgr.GetServerInstance().StartMNEDCServer(deviceIDFilePath)
-                } else if strings.Compare(strings.ToLower(mnedc), "client") == 0 {
-                        if isSecured {
-                                mnedcmgr.GetClientInstance().SetCertificateFilePath(certificateFilePath)
-                        }
-                        go mnedcmgr.GetClientInstance().StartMNEDCClient(deviceIDFilePath, mnedcServerConfig)
-                }
+		if strings.Compare(strings.ToLower(mnedc), "server") == 0 {
+			if isSecured {
+				mnedcmgr.GetServerInstance().SetCipher(dummy.GetCipher(cipherKeyFilePath))
+				mnedcmgr.GetServerInstance().SetCertificateFilePath(certificateFilePath)
+			} else {
+				mnedcmgr.GetServerInstance().SetCipher(sha256.GetCipher(cipherKeyFilePath))
+			}
+			go discoverymgr.GetInstance().StartMNEDCServer(deviceIDFilePath)
+		} else if strings.Compare(strings.ToLower(mnedc), "client") == 0 {
+			if isSecured {
+				mnedcmgr.GetClientInstance().SetCertificateFilePath(certificateFilePath)
+			}
+			go discoverymgr.GetInstance().StartMNEDCClient(deviceIDFilePath, mnedcServerConfig)
+		}
 	} else {
 		if strings.Contains(buildTags, "mnedcserver") {
 			if isSecured {
@@ -212,12 +213,12 @@ func orchestrationInit() error {
 			} else {
 				mnedcmgr.GetServerInstance().SetCipher(sha256.GetCipher(cipherKeyFilePath))
 			}
-			go mnedcmgr.GetServerInstance().StartMNEDCServer(deviceIDFilePath)
+			go discoverymgr.GetInstance().StartMNEDCServer(deviceIDFilePath)
 		} else if strings.Contains(buildTags, "mnedcclient") {
 			if isSecured {
 				mnedcmgr.GetClientInstance().SetCertificateFilePath(certificateFilePath)
 			}
-			go mnedcmgr.GetClientInstance().StartMNEDCClient(deviceIDFilePath, mnedcServerConfig)
+			go discoverymgr.GetInstance().StartMNEDCClient(deviceIDFilePath, mnedcServerConfig)
 		}
 	}
 

build.sh

@@ -34,11 +34,11 @@ PKG_LIST=(
         "controller/servicemgr/executor/containerexecutor"
         "controller/servicemgr/executor/nativeexecutor"
         "controller/servicemgr/notification"
-        "controller/mnedcmgr"
-        "controller/mnedcmgr/client"
-        "controller/mnedcmgr/connectionutil"
-        "controller/mnedcmgr/server"
-        "controller/mnedcmgr/tunmgr"
+        "controller/discoverymgr/mnedc"
+        "controller/discoverymgr/mnedc/client"
+        "controller/discoverymgr/mnedc/connectionutil"
+        "controller/discoverymgr/mnedc/server"
+        "controller/discoverymgr/mnedc/tunmgr"
         "controller/storagemgr/storagedriver"
         "db/bolt/common"
         "db/bolt/configuration"

glide.yaml

@@ -33,11 +33,11 @@ ignore:
   - controller/servicemgr/executor/containerexecutor
   - controller/servicemgr/executor/nativeexecutor
   - controller/servicemgr/notification
-  - controller/mnedcmgr
-  - controller/mnedcmgr/client
-  - controller/mnedcmgr/connectionutil
-  - controller/mnedcmgr/server
-  - controller/mnedcmgr/tunmgr
+  - controller/discoverymgr/mnedc
+  - controller/discoverymgr/mnedc/client
+  - controller/discoverymgr/mnedc/connectionutil
+  - controller/discoverymgr/mnedc/server
+  - controller/discoverymgr/mnedc/tunmgr
   - controller/storagemgr/storagedriver
   - db/helper
   - db/bolt/common

src/common/sigmgr/sigmgr.go

@@ -23,8 +23,8 @@ import (
 	"os/signal"
 	"syscall"
 
-	"controller/mnedcmgr/client"
-	"controller/mnedcmgr/server"
+	"controller/discoverymgr/mnedc/client"
+	"controller/discoverymgr/mnedc/server"
 )
 
 const (

src/controller/discoverymgr/discovery.go

@@ -28,6 +28,7 @@ import (
 
 	errors "common/errors"
 	networkhelper "common/networkhelper"
+	mnedc "controller/discoverymgr/mnedc"
 	wrapper "controller/discoverymgr/wrapper"
 
 	configurationdb "db/bolt/configuration"
@@ -56,6 +57,8 @@ type Discovery interface {
 	NotifyMNEDCBroadcastServer() error
 	MNEDCReconciledCallback()
 	GetDeviceID() (id string, err error)
+	StartMNEDCClient(string, string)
+	StartMNEDCServer(string)
 	client.Setter
 	cipher.Setter
 }
@@ -383,7 +386,6 @@ func setDeviceID(UUIDPath string) (UUIDstr string, err error) {
 	return UUIDstr, err
 }
 
-
 func getPlatform() (platform string, err error) {
 	platform, err = getSystemDB(systemdb.Platform)
 	if err != nil {
@@ -686,6 +688,16 @@ func (d *DiscoveryImpl) MNEDCReconciledCallback() {
 	}
 }
 
+//StartMNEDCClient Starts MNEDC client
+func (d *DiscoveryImpl) StartMNEDCClient(deviceIDFilePath, mnedcServerConfig string) {
+	mnedc.GetClientInstance().StartMNEDCClient(deviceIDFilePath, mnedcServerConfig)
+}
+
+//StartMNEDCServer Starts MNEDC server
+func (d *DiscoveryImpl) StartMNEDCServer(deviceIDFilePath string) {
+	mnedc.GetServerInstance().StartMNEDCServer(deviceIDFilePath)
+}
+
 // ClearMap makes map empty and only leaves my device info
 func clearMap() {
 	log.Println(logPrefix, "[clearMap]")
@@ -819,4 +831,4 @@ func activeDiscovery() {
 // It Clears Map
 func resetServer(ips []net.IP) {
 	wrapperIns.ResetServer(ips)
-}
+}

src/controller/mnedcmgr/client/client.go → src/controller/discoverymgr/mnedc/client/client.go

@@ -26,9 +26,11 @@ import (
 	"sync"
 	"time"
 
-	"controller/discoverymgr"
-	"controller/mnedcmgr/connectionutil"
-	"controller/mnedcmgr/tunmgr"
+	restclient "restinterface/client"
+	//"controller/discoverymgr"
+	networkhelper "common/networkhelper"
+	"controller/discoverymgr/mnedc/connectionutil"
+	"controller/discoverymgr/mnedc/tunmgr"
 
 	"github.com/songgao/water"
 )
@@ -61,18 +63,21 @@ type Client struct {
 	serverPort      string
 	deviceID        string
 	configPath      string
+	clientAPI       restclient.Clienter
 }
 
 var (
 	clientIns      *Client
 	tunIns         tunmgr.Tun
 	networkUtilIns connectionutil.NetworkUtil
-	discoveryIns   discoverymgr.Discovery
+	networkIns     networkhelper.Network
+	//discoveryIns   discoverymgr.Discovery
 )
 
 const (
-	waitDelay  = 150 * time.Millisecond
-	retryDelay = 5 * time.Second
+	waitDelay                = 150 * time.Millisecond
+	retryDelay               = 5 * time.Second
+	mnedcBroadcastServerPort = 3333
 )
 
 //MNEDCClient declares methods related to MNEDC client
@@ -88,13 +93,16 @@ type MNEDCClient interface {
 	ParseVirtualIP(string) error
 	TunReadRoutine()
 	TunWriteRoutine()
+	NotifyBroadcastServer(configPath string) error
+	SetClient(clientAPI restclient.Clienter)
 }
 
 func init() {
 	clientIns = &Client{}
 	tunIns = tunmgr.GetInstance()
 	networkUtilIns = connectionutil.GetInstance()
-	discoveryIns = discoverymgr.GetInstance()
+	networkIns = networkhelper.GetInstance()
+	//discoveryIns = discoverymgr.GetInstance()
 }
 
 //GetInstance returns MNEDCClient interface instance
@@ -403,14 +411,73 @@ func (c *Client) TunWriteRoutine() {
 func (c *Client) NotifyClose() {
 	logPrefix := "[NotifyClose]"
 	log.Println(logPrefix, "MNEDC connection closed")
-	discoveryIns.MNEDCClosedCallback()
+	//discoveryIns.MNEDCClosedCallback()
 }
 
 //ConnectionReconciled handles the case when MNEDC connection is re-established
 func (c *Client) ConnectionReconciled() {
 	logPrefix := "[connectionReIstablish]"
 	log.Println(logPrefix, "MNEDC connection reistablished")
-	discoveryIns.MNEDCReconciledCallback()
+	//discoveryIns.MNEDCReconciledCallback()
+	//notifyBroadcastServer()
+	c.NotifyBroadcastServer(c.configPath)
+}
+
+//NotifyBroadcastServer sends request to broadcast server
+func (c *Client) NotifyBroadcastServer(configPath string) error {
+	logPrefix := "[RegisterBroadcast]"
+	log.Println(logTag, "Registering to Broadcast server")
+	c.configPath = configPath
+	virtualIP, err := networkIns.GetVirtualIP()
+	if err != nil {
+		log.Println(logPrefix, "Cant register to Broadcast server, virtual IP error", err.Error())
+		return err
+	}
+
+	privateIP, err := networkIns.GetOutboundIP()
+	if err != nil {
+		log.Println(logPrefix, "Cant register to Broadcast server, outbound IP error", err.Error())
+		return err
+	}
+
+	file, err := os.Open(configPath)
+
+	if err != nil {
+		log.Println(logPrefix, "cant read config file from", configPath, err.Error())
+		return err
+	}
+	defer file.Close()
+
+	scanner := bufio.NewScanner(file)
+	scanner.Split(bufio.ScanLines)
+
+	scanner.Scan()
+	serverIP := scanner.Text()
+
+	go func() {
+
+		if c.clientAPI == nil {
+			log.Println(logPrefix, "Client is nil, returning")
+			err = errors.New("Client is nil")
+			return
+		}
+		err = c.clientAPI.DoNotifyMNEDCBroadcastServer(serverIP, mnedcBroadcastServerPort, c.deviceID, privateIP, virtualIP)
+		if err != nil {
+			log.Println(logPrefix, "Cannot register to Broadcast server", err.Error())
+		}
+	}()
+
+	time.Sleep(5 * time.Second)
+	if err != nil {
+		return err
+	}
+
+	return nil
+}
+
+//SetClient sets the rest client
+func (c *Client) SetClient(clientAPI restclient.Clienter) {
+	c.clientAPI = clientAPI
 }
 
 func getMNEDCServerAddress(path string) (string, string, error) {

src/controller/mnedcmgr/client/client_test.go → src/controller/discoverymgr/mnedc/client/client_test.go

@@ -28,9 +28,9 @@ import (
 	"github.com/golang/mock/gomock"
 	"github.com/songgao/water"
 
+	networkUtilMocks "controller/discoverymgr/mnedc/connectionutil/mocks"
 	discoveryMocks "controller/discoverymgr/mocks"
-	networkUtilMocks "controller/mnedcmgr/connectionutil/mocks"
-	tunMocks "controller/mnedcmgr/tunmgr/mocks"
+	tunMocks "controller/discoverymgr/mnedc/tunmgr/mocks"
 )
 
 const (