[CloudSync] Adding the API to be exposed to thirdparty for Data Publish

[nitu-s-gupta]

Signed-off-by: Nitu Gupta [email protected]

Description

provide mechanism to expose API that can be used by third party apps to publish data to MQTT broker running on AWS endpoint

Fixes # (#382 )

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

1.MQTT mosquitto broker is configured to be running in the AWS endpoint.
2. The edge orchestration is build and run using following command with option CLOUD_SYNC set to true

docker run -it -d --privileged --network="host" --name edge-orchestration -e CLOUD_SYNC=true -v /var/edge-orchestration/:/var/edge-orchestration/:rw -v /var/run/docker.sock:/var/run/docker.sock:rw -v /proc/:/process/:ro  lfedge/edge-home-orchestration-go:latest

3. The logs are checked using the command

docker logs -f edge-orchestration

4. From the another terminal/post make a curl command as follows to publish data using home edge to the broker running on AWS endpoint

curl --location --request POST 'http://192.168.1.107:56001/api/v1/orchestration/cloudsyncmgr' \
> --header 'Content-Type: text/plain' \
> --data-raw '{
>     "appid": "TV1",
>     "payload": "{Another data from TV1}",
>     "topic": "home/livingroom",
>     "url" : "ec2-54-144-110-26.compute-1.amazonaws.com"
> }'

5. You should obtain the following message for successful publish

{"Message":"Data published successfully to Cloud","RemoteTargetInfo":"","ServiceName":""}

Test Configuration:

• OS type & version: (Ubuntu 20.04)
• Hardware: (x86-64)
• Edge Orchestration Release: (v1.1.0)

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

No Coverage information
12.2% Duplication

[tiokim]

Thanks for the contribution.
Please take a look at my comments.

[tiokim]

How long have you took? How about calling sleep function?

[nitu-s-gupta]

If using sleep what time value would be used. Its not always same in settting client

[tiokim]

If I call this 10 times with the same host, will 10 mqtt client go routines be created?

[nitu-s-gupta]

currently it is not storing the client data. Also one more thing when same host is sending the conenctn request the previous connection is closed and new is opened.

[suresh-lc]

Wanted to make the base code with single connection with the client. Going forward we think of scenarios where multiple service applications can call the send API to send data to different broker URL's. So in that case maintaining separate mqtt client instance for each service application would be better(and only one instance for each host). Use of db to maintain the same or so could be option. We plan to do this once the base code is merged as part of next steps.

[tdrozdovsky]

LGTM

[tiokim]

LGTM Thanks!

[suresh-lc]

LGTM

[MoonkiHong]

+1