From 105e7113d84f1520dfdd770d7c2aa113711fdc64 Mon Sep 17 00:00:00 2001 From: Peter Donovan Date: Sun, 16 Jun 2024 12:07:18 -0700 Subject: [PATCH 1/2] Try a more brute-force approach to removing GCC --- .github/workflows/lsp-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lsp-tests.yml b/.github/workflows/lsp-tests.yml index aba672d380..f3de8f9cdc 100644 --- a/.github/workflows/lsp-tests.yml +++ b/.github/workflows/lsp-tests.yml @@ -31,7 +31,7 @@ jobs: run: sudo apt-get remove clang-* if: ${{ runner.os == 'Linux' }} - name: Uninstall packages MacOS - run: brew uninstall --ignore-dependencies gcc + run: sudo rm -f $(which gcc) if: ${{ runner.os == 'macOS' }} - name: Uninstall packages Windows shell: pwsh @@ -68,7 +68,7 @@ jobs: - name: Setup Python uses: actions/setup-python@v4 with: - python-version: '3.10' + python-version: "3.10" - name: Run language server Python tests without PyLint run: ./gradlew core:integrationTest --tests org.lflang.tests.lsp.LspTests.pythonValidationTestSyntaxOnly core:integrationTestCodeCoverageReport - name: Install pylint From 47b3bec18c7e5c36ee8a9712960242e955eaf003 Mon Sep 17 00:00:00 2001 From: Peter Donovan Date: Sun, 16 Jun 2024 12:30:11 -0700 Subject: [PATCH 2/2] Give up trying to uninstall GCC This is what happens in CI: > Run sudo rm -f $(which gcc) rm: /usr/bin/gcc: Read-only file system This seems to indicate that there is no way to move or delete the GCC binary, and it will not work to change the PATH to not include /usr/bin because that will break a lot of things. Therefore, there probably is no easy way to make GCC invisible on the system, so if we want a quick fix, then we should give up exercising that code path in CI. The code path under test is already difficult to maintain anyway and works on a "best effort" basis. --- .github/workflows/lsp-tests.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/lsp-tests.yml b/.github/workflows/lsp-tests.yml index f3de8f9cdc..0a50fbf85a 100644 --- a/.github/workflows/lsp-tests.yml +++ b/.github/workflows/lsp-tests.yml @@ -30,9 +30,6 @@ jobs: - name: Uninstall packages Ubuntu run: sudo apt-get remove clang-* if: ${{ runner.os == 'Linux' }} - - name: Uninstall packages MacOS - run: sudo rm -f $(which gcc) - if: ${{ runner.os == 'macOS' }} - name: Uninstall packages Windows shell: pwsh run: |