Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit connect/disconnect eligibility logic #221

Open
axmmisaka opened this issue Aug 25, 2023 · 0 comments
Open

Revisit connect/disconnect eligibility logic #221

axmmisaka opened this issue Aug 25, 2023 · 0 comments

Comments

@axmmisaka
Copy link
Collaborator

Currently, to make a connection, two checks are performed:

  1. The parent or grandparent of the component being connected must be the component performing the operation
  2. The component performing the operation must possess the key to the component being connected

I feel that these two checks overlap and is redundant. It would be best to choose one among these two, or come up with a regression test that will fail if one is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant