Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target language validation: Some errors are reported multiple times #67

Open
petervdonovan opened this issue Jul 8, 2022 · 0 comments
Labels
bug Something isn't working diagnostics Error, warning, and info message reporting

Comments

@petervdonovan
Copy link
Contributor

Example:
Screenshot from 2022-07-07 22-40-39

In this case, it happens because the same line appears in multiple places in multiple different generated files. The file name and line number information from each of the different diagnostic messages should be kept, but it would be nice if the information could be consolidated.

If it is too hard to combine the different messages, we could use a similarity score (or a rule that simply ignores the file and position given in [] at the end) to determine whether to show the additional messages. It should be acceptable to hide messages because all errors/warnings should be resolved eventually, and when they are resolved, any that remain should become visible.

@petervdonovan petervdonovan added invalid This doesn't seem right diagnostics Error, warning, and info message reporting bug Something isn't working and removed invalid This doesn't seem right labels Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working diagnostics Error, warning, and info message reporting
Projects
None yet
Development

No branches or pull requests

1 participant