Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSO doesn’t nor enables users to set storage size #153

Open
TheOneric opened this issue Nov 15, 2022 · 1 comment
Open

JSO doesn’t nor enables users to set storage size #153

TheOneric opened this issue Nov 15, 2022 · 1 comment
Labels

Comments

@TheOneric
Copy link
Member

ASS rendering depends on the original video’s storage resolution.
Even if we can somehow obtain the video resolution of the current associated video stream, this may not be correct if there are multiple resolutions available to choose from or resolution is dynamically adjusted for bandwidth. Thus JSO should at least (also?) provide a means for users of the regular JS interface to manually set storage size from e.g. some out-of-band metadata.

Currently all subtitles (without LayoutRes{X,Y}) for which libass’ fallback guess is wrong and use affected features thus render incorrectly.

@TheOneric TheOneric added the bug label Nov 15, 2022
@TheOneric TheOneric changed the title JSO does not and doesn't enable users to set storage size JSO doesn’t nor enables users to set storage size Nov 15, 2022
@ThaUnknown
Copy link

https://github.com/ThaUnknown/jassub/blob/main/src/jassub.js#L286
videos have a resize event which fires whenever the video resolution changes, be that because the video track was changed or because of some encoding black magic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants