-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser freezing under 'heavy' subs #46
Comments
Could you share the subs you're having trouble with? |
@Yay295 Thanks for replying. Here is the ASS file along with the fonts used: https://drive.google.com/drive/folders/10li-vh6EO-0YfvK3GZqTW0Tqm1jfNI31?usp=sharing |
@Yay295 did you get the chance to look into it? |
A bit, but I don't have a conclusion. It is a big file, but it doesn't actually have anything too complex in it, and you can see from this demo that it can handle similar files (mostly) fine. I think it's probably just the sheer number of subtitle "lines" in the file. For the OP, some of the individual letters are composed of 50 or more lines to make it look how it does. |
In my experience, at least in chrome, freeze happens when cache grows too large (or too fast?). Seems like memory reallocations in emscripten are becoming too expensive. But I don't really know much about it. |
Scratch my previous comment, through maybe its a different issue. subtitles-octopus.js
subtitles-octopus-worker.js
Here is some stats.
After:
|
@no1d I'm testing your code, and it seems that solved the problem. |
I recently got JavascriptSubtitlesOctopus up and running and testest a few videos, most which work great, but I noticed a couple videos with heavy intro subs (animation and effects) overloads my browser and freezes. From my understanding it should be able to handle it without lag. Perhaps I need to adjust some configurations? Below is a screenshot of the console output log.
The text was updated successfully, but these errors were encountered: