Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second-level subdomains don't work properly #4

Open
xylobol opened this issue Dec 1, 2023 · 3 comments
Open

Second-level subdomains don't work properly #4

xylobol opened this issue Dec 1, 2023 · 3 comments

Comments

@xylobol
Copy link

xylobol commented Dec 1, 2023

As the title says, I can't perform operations on second-level domains (e.g. sub2.sub1.example.com). I believe this is because the Porkbun API wants only the example.com in the request URL, but this seems to send sub1.example.com. I've stumbled upon this by trying to get a wildcard cert off a subdomain (*.sub.example.com) using Caddy's Porkbun plugin, and following the errors from there. After thumbing through this codebase, it seems like it'd be a bit of an involved change, so I want the maintainers' opinions before trying to put in a PR myself for it.

@Niallfitzy1
Copy link
Collaborator

Interesting.

Can you test if it's possible with other providers e.g. CloudFlare?

I based this pretty closely on that implementation.

If it's possible there but not here, I'd be interested in seeing what a change to accommodate it would look like.

@xylobol
Copy link
Author

xylobol commented Dec 1, 2023

Unfortunately, I can't, as I don't have accounts with any other DNS service (unless you'd like me to try Azure DNS, but that will take a few days). It looks like the issue may be relevant for Cloudflare as well, though: https://caddy.community/t/wildcard-certificates-for-subdomains-with-cloudflare/9455/5

@Niallfitzy1
Copy link
Collaborator

Interesting

I'd be hesitant to diverge too far from the other libraries on functionality since I'm not actively working on this & focused on the wildcard/suddomain use case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants