-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for poldek_rpm backend #6
base: master
Are you sure you want to change the base?
Conversation
--use-installed is not implemented, need to dig more what the method is supposed to return
Thanks for your interest in supermin, and sorry for the late reply. This work was done on supermin 4.x. Earlier this year, supermin has been rewritten, and the 5.x series has a slightly different, but simplier, interface for package handlers. In particular, the rpm-based package managers now share the rpm querying code, which uses librpm directly since supermin 5.1.11; thus, as long as librpm can be used, you only need to implement the package downloading (extracting of .rpm files is in a shared function).
This is not needed anymore, deciding whether use the installed files on the host is done outside the package handlers.
That function is gone, now there are two simplier functions to
When updating this patches for supermin 5.x, make sure that Please note supermin's development happens mostly on the libguestfs mailing list, see https://www.redhat.com/mailman/listinfo/libguestfs, so patches should be sent there (we do not use github's pull requests features). Looking forward to see the updated patch for this for supermin 5.x! |
you say librpm, but which version? rpm.org one or rpm5.org one? |
The one that is built with the rpm provided with the distro. Unless the API changed of rpm5 changed too much compared to rpm 4.x, it might work. At worst, it is about creating a totally different |
the librpm v5 api is indeed different, here's the patch: http://git.pld-linux.org/?p=packages/supermin.git;a=history;f=supermin-rpm5.patch |
Hmm I see... would you please send the whole poldek porting patch (the proposed changes for librpm, plus the integration with poldek) to our mailing list, so we can discuss there better? |
based on various rpm-based backends. --use-installed is not implemented, need to dig more what the method is
supposed to return (did not found any docs yet)
but i would like to hear what ph_resolve_dependencies_and_download is supposed to take as input and what it must return as output :)