Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid comment regex in single_header.py #79

Open
TheCatPlusPlus opened this issue Sep 29, 2016 · 2 comments
Open

Invalid comment regex in single_header.py #79

TheCatPlusPlus opened this issue Sep 29, 2016 · 2 comments

Comments

@TheCatPlusPlus
Copy link

TheCatPlusPlus commented Sep 29, 2016

commentParser2 regex matches line *this = impl_->clone(); which breaks the built header by outputting

    void writable_() {
        if (impl_.use_count() > 1) {
        }
    }

Invalid output noticed by Cicada.

@TheCatPlusPlus
Copy link
Author

TheCatPlusPlus commented Sep 29, 2016

Actually that's in Catch too as '^ \*' so maybe it was actually meant to catch the comment continuation lines? Not sure. Definitely shouldn't match indentation freely.

@melak47
Copy link

melak47 commented Mar 28, 2017

Is removing two comment blocks (one in <nonius/param.h++>, one in <nonius/detail/cpptemp.h>) really worth trying to parse them with regex patterns, while over 650 lines of // comments are preserved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants