You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a branch called numeric_vector. There are a few parts to this branch:
Add libmesh's numeric vector stuff to queso's build system
Add GslNumericVector/GslSparseMatrix sublcasses of NumericVector/SparseMatrix that wrap around GslVector/GslMatrix
Add explicit instantiations for queso's classes around the classes in 2.
Add explicit instantiations for queso's classes around EigenSparse(Vector|Matrix)
Items 3 and 4 require adding queso methods to these classes so that they compile with queso's "vector/matrix api"
Take what's common out of 2. and 3. and put it in the base classes NumericVector/SparseMatrix
Add explicit instantiation on of queso's classes around NumericVector/SparseMatrix
Wherever queso or user code uses queso's api for interacting with vectors and matrices, use libmesh's api instead
Remove the explicit instantiations around GslNumericVector/EigenSparseVector and the matrix equivalents
I've done up to item 4, but I haven't updated the test suite to cover that case. All of queso compiles, links, and passes tests (at least locally for me, I'm sure I missed stuff) with explicit instantiations for Eigen (so up to item 3 above) but the tests only hit the explicit instantiations around GslNumericVector and GslSparseMatrix.
There are definitely code stinks in this branch:
I'm not properly generated the libmesh_config.h files from queso's build system (it should really all go into queso_config.h)
The optimisation routines will need to be updated to use nlopt or similar optimisation package
The tests need to be updated to cover Eigen (go through every source file in the test directory and replace: a) GslNumericVector with EigenSparseVector; and b) GslSparseMatrix with EigenSparseMatrix.
I'm switching employers and didn't get all of this finished, so I'm documenting the state of it here so it can be picked up. I'm sure I've forgotten things so I'll add stuff as I remember it.
People probably interested in this ticket are @roystgnr and @briadam
The text was updated successfully, but these errors were encountered:
This issue is a bear.
I have a branch called
numeric_vector
. There are a few parts to this branch:I've done up to item 4, but I haven't updated the test suite to cover that case. All of queso compiles, links, and passes tests (at least locally for me, I'm sure I missed stuff) with explicit instantiations for Eigen (so up to item 3 above) but the tests only hit the explicit instantiations around GslNumericVector and GslSparseMatrix.
There are definitely code stinks in this branch:
GslNumericVector
withEigenSparseVector
; and b)GslSparseMatrix
withEigenSparseMatrix
.I'm switching employers and didn't get all of this finished, so I'm documenting the state of it here so it can be picked up. I'm sure I've forgotten things so I'll add stuff as I remember it.
People probably interested in this ticket are @roystgnr and @briadam
The text was updated successfully, but these errors were encountered: