Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring goodbye packets are sent on shutdown #27

Open
kingosticks opened this issue Mar 25, 2021 · 0 comments
Open

Ensuring goodbye packets are sent on shutdown #27

kingosticks opened this issue Mar 25, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@kingosticks
Copy link

As discussed here librespot-org/librespot#676 (comment) we don't seem to get "goodbye" mDNS messages when stopping the librespot process which leaves the service lingering in clients. I think it's due to this TODO:

libmdns/src/lib.rs

Lines 202 to 207 in 4829c5c

impl Drop for Shutdown {
fn drop(&mut self) {
self.0.send_shutdown();
// TODO wait for tasks to shutdown
}
}

I had a bash at a fix, it is not pretty...

kingosticks added a commit to kingosticks/libmdns that referenced this issue Mar 25, 2021
…rg#27).

Ideally the task within our "mdns-responder" thread would block
until all the futures actually return Poll::Ready but I can't get
that to work, hence the explicit extra blocking I have added.
@willstott101 willstott101 added the bug Something isn't working label Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants