Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS parsing can cause crash due to infinite recursion #56

Open
jmaygarden opened this issue Jul 5, 2024 · 1 comment
Open

DNS parsing can cause crash due to infinite recursion #56

jmaygarden opened this issue Jul 5, 2024 · 1 comment

Comments

@jmaygarden
Copy link

The name parsing uses a u16 offset and recurses without checking if the value is zero. That may cause an infinite loop that blows up the stack and crashes the process.

See tailhook/dns-parser@c840c17 for a fix.

@willstott101
Copy link
Contributor

Thanks, I'll try and get this integrated this weekend. Medium-term I think it would be best for this library to switch to a maintained external DNS serialization library though.

willstott101 added a commit that referenced this issue Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants