Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move embedding pointer out of the Status object #20

Open
LTLA opened this issue Aug 20, 2024 · 0 comments
Open

Move embedding pointer out of the Status object #20

LTLA opened this issue Aug 20, 2024 · 0 comments

Comments

@LTLA
Copy link
Collaborator

LTLA commented Aug 20, 2024

Makes it difficult to reason about, copy, etc. Everyone has to be aware of resetting the pointer if the lifetime of the array expires. Much better to be explicit about it, at the cost of requiring the user to pass in the same embedding pointer multiple times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant