Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default build type? #11616

Open
slouken opened this issue Dec 9, 2024 · 2 comments
Open

Default build type? #11616

slouken opened this issue Dec 9, 2024 · 2 comments
Assignees
Milestone

Comments

@slouken
Copy link
Collaborator

slouken commented Dec 9, 2024

Can we default the build type to RelWithDebInfo for SDL and the satellite libraries? Can we also add a note to the cmake output if tests are not enabled?

I'd like users to be in a good position if they naively just run cmake, so they get good performance and have the ability to debug and know that there are test programs available. That should help the newbie experience a lot, as seen in this video: https://www.youtube.com/watch?v=PuE98lipGU8

@slouken slouken added this to the 3.2.0 milestone Dec 9, 2024
@madebr
Copy link
Contributor

madebr commented Dec 9, 2024

RelWithDebInfo for SDL3 is the default since 48b6b93.

You mean something like this?

--  Build Shared Library: ON    (SDL_SHARED)
--  Build Static Library: ON    (SDL_STATIC)
--  Build Test Library:   ON    (SDL_TEST_LIBRARY)
--  Build Tests:          ON    (SDL_TESTS, needs SDL_TEST_LIBRARY)
--  Build Examples:       ON    (SDL_EXAMPLES)
--  Build Static Library with Position Independent Code: OFF

@slouken
Copy link
Collaborator Author

slouken commented Dec 9, 2024

RelWithDebInfo for SDL3 is the default since 48b6b93.

Great! Can you roll this out to the satellite libraries as well?

You mean something like this?

--  Build Shared Library: ON    (SDL_SHARED)
--  Build Static Library: ON    (SDL_STATIC)
--  Build Test Library:   ON    (SDL_TEST_LIBRARY)
--  Build Tests:          ON    (SDL_TESTS, needs SDL_TEST_LIBRARY)
--  Build Examples:       ON    (SDL_EXAMPLES)
--  Build Static Library with Position Independent Code: OFF

No, I mean something a little more verbose, e.g.

You can build test and sample programs by running cmake with -DSDL_TESTS=ON

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants