Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalog.ts: crash when e.reason not a string #16295

Closed
kraktus opened this issue Oct 30, 2024 · 1 comment · Fixed by #16296
Closed

Permalog.ts: crash when e.reason not a string #16295

kraktus opened this issue Oct 30, 2024 · 1 comment · Fixed by #16296
Labels

Comments

@kraktus
Copy link
Member

kraktus commented Oct 30, 2024

Some error break permalog.ts, which is annoying since it call itself back on every error/unhandled promise. Eventually crashing the page.

context https://discord.com/channels/280713822073913354/352976626558042122/1301212947804323860

@kraktus kraktus added the bug label Oct 30, 2024
@kraktus kraktus changed the title TS: EscapeHtml crashing on particular string Permalog.ts: crash when Oct 30, 2024
@kraktus kraktus changed the title Permalog.ts: crash when Permalog.ts: crash when e.reason not a string Oct 30, 2024
@kraktus
Copy link
Member Author

kraktus commented Oct 30, 2024

a317a46#diff-ed9feaa882736ee2bff4d3a3dacbb32078212ed1ae48fc013edf92f1093f2994R538-R540

To reproduce (quite involved) follow procedure of PR #16293 then open localhost:9663/training/FJtVd. Fail the puzzle, then go to Kh2, open the ceval with multi lines >=2, wait for depth >=20 and see the page burn.

kraktus added a commit to kraktus/lila that referenced this issue Oct 30, 2024
https://developer.mozilla.org/en-US/docs/Web/API/PromiseRejectionEvent/reason

`reason read-only property is any JavaScript value or Object which provides the reason passed into Promise.reject()`

fix lichess-org#16295
kraktus added a commit that referenced this issue Oct 30, 2024
…6296)

https://developer.mozilla.org/en-US/docs/Web/API/PromiseRejectionEvent/reason

`reason read-only property is any JavaScript value or Object which provides the reason passed into Promise.reject()`

fix #16295

Co-authored-by: kraktus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant