Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd 1-pixel misalignment of shading after premove #16381

Closed
samthegitguy opened this issue Nov 9, 2024 · 5 comments · Fixed by #16434
Closed

Odd 1-pixel misalignment of shading after premove #16381

samthegitguy opened this issue Nov 9, 2024 · 5 comments · Fixed by #16434
Labels

Comments

@samthegitguy
Copy link

Exact URL of where the bug happened

https://lichess.org/nJGBROyvdDb9

Steps to reproduce the bug

  1. Play any move
  2. Play any premove

What did you expect to happen?

A blue color appears on the initial and destination squares.

What happened instead?

The blue shading appears one pixel misaligned from the square.

Operating system

Windows 11

Browser and version (or alternate access method)

Opera GX 110.4

Additional information

image

@johndoknjas
Copy link
Contributor

johndoknjas commented Nov 12, 2024

I get it as well on the default board theme:

image

However on the board theme I currently use, I don't seem to:

image

From my tests, the themes I get the issue on are brown, wood, blue, ic, green, purple, and newspaper. Possibly for olive and grey too, can't really tell for them. Of those first 7 themes though, 6 (except wood) have an svg file-ext in _boards.scss (and there are no other svgs in _boards.scss). So maybe this has something to do with the bug.

@johndoknjas
Copy link
Contributor

johndoknjas commented Nov 13, 2024

#16408 should fix this issue for all the board themes except "newspaper" and "wood". For the former it's probably not worth fixing (and not too noticeable), while for the latter it's still a mystery. Wood is the only non-svg that had this issue.

@johndoknjas
Copy link
Contributor

@samthegitguy I'd recommend keeping this open for now since it's fixed for 5 themes, but not for newspaper and wood.

@samthegitguy samthegitguy reopened this Nov 17, 2024
@samthegitguy
Copy link
Author

Right - I assumed we weren't going to fix that problem.

@johndoknjas
Copy link
Contributor

Probably not for newspaper but it's still unclear what the issue with wood is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants