Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect good move color #16559

Open
dav1312 opened this issue Dec 10, 2024 · 2 comments · May be fixed by #16611
Open

Incorrect good move color #16559

dav1312 opened this issue Dec 10, 2024 · 2 comments · May be fixed by #16611
Labels
bug good first issue Narrow in scope (but not necessarily easy) no scala

Comments

@dav1312
Copy link

dav1312 commented Dec 10, 2024

Exact URL of where the bug happened

https://lichess.org/study/yP5cyecR/OPtJTsIu#25

Steps to reproduce the bug

Hover over a move that is marked as good (!)

What did you expect to happen?

Green color

What happened instead?

Black color

image

Operating system

W10

Browser and version (or alternate access method)

Chrome

Additional information

Changing the color from the reference to the other variable to the color of the variable makes it work but it seems like a lame fix

lila/ui/common/css/theme/_default.scss

Line 33 in 58f0a1a

$c-good: $c-secondary;

lila/ui/tree/css/_tree.scss

Line 43 in 58f0a1a

background: $m-good_bg--mix-30;

@dav1312 dav1312 added the bug label Dec 10, 2024
@ornicar ornicar added good first issue Narrow in scope (but not necessarily easy) no scala labels Dec 12, 2024
@seren5240
Copy link
Contributor

seren5240 commented Dec 13, 2024 •
edited
Loading

This seems to occur because the move is currently selected. If another move is clicked, the green colour populates as usual. Is that not the expected behaviour?

@dav1312
Copy link
Author

dav1312 commented Dec 13, 2024 •
edited
Loading

This seems to occur because the move is currently selected. If another move is clicked, the green colour populates as usual. Is that not the expected behaviour?

The background color is the issue, not the text color
image

The expected behaviour is what happens to the rest of annotations
image

@FawzyAshraf FawzyAshraf linked a pull request Dec 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue Narrow in scope (but not necessarily easy) no scala
Projects
Lichess Good First Issues
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable sass parser in ui/build to parse indirect color assignments FawzyAshraf/lila
3 participants
@ornicar @dav1312 @seren5240