Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link preview is not working for Whatsapp Web #925

Open
drakonux opened this issue Feb 16, 2021 · 3 comments
Open

Link preview is not working for Whatsapp Web #925

drakonux opened this issue Feb 16, 2021 · 3 comments

Comments

@drakonux
Copy link
Member

drakonux commented Feb 16, 2021

Description
The preview of a link from liferay.design doesn't work.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://liferay.design/careers'
  2. Copy the URL
  3. Open WhatsApp Web
  4. Open a conversation with a friend
  5. Paste URL and Send

Current behavior
image

image

Expected behavior
A default image with a description or something summarizing the content of that link

Desktop

  • OS: Windows 10
  • Browser: Microsoft Edge
  • Version: 88.0.705.68 (64 bits)

Mobile

  • OS: iOS
  • Browser: Native App
  • Version: 2.21.21.22
@plhnk
Copy link
Member

plhnk commented Feb 19, 2021

Thanks for opening @drakonux ! Can you try adding a / at the very end? I've noticed that some platforms don't recognize the page as valid unless that's there... need to look into what it would take to solve this on our end :)

@drakonux
Copy link
Member Author

drakonux commented Feb 19, 2021

You are right Paul. It works by adding the "/" at the end! 🦾 FYI I just copied the URL as it is in liferay.design so...

@plhnk
Copy link
Member

plhnk commented Mar 11, 2021

Looking into this briefly — I came across this dev.to post.

As I understand, the trailing slash is generally a good thing to have (for SEO, basically it indicates there's additional content) — what's weird is that currently we do have 301 redirects in place, which is why when you navigate to liferay.design/careers, you get a page. In slack, link previews are generated as expected, but in some (like Whatsapp) they don't...

So — I believe the connundrum is...do we want to:

  1. follow SEO best practices (i.e. keep the trailing slash)
  2. ensure good link previews everywhere

What I will do next is a little more research into...

  1. is a 301 the right redirect?
  2. test by toggling the Netlify url prettifying

your thoughts / research are most welcome as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants