Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services are private by default (Symfony 4) #20

Open
frostieDE opened this issue Apr 28, 2018 · 0 comments
Open

Services are private by default (Symfony 4) #20

frostieDE opened this issue Apr 28, 2018 · 0 comments

Comments

@frostieDE
Copy link
Contributor

frostieDE commented Apr 28, 2018

Starting with Symfony 4, services are marked private per default, which means that you cannot get services by calling $container->get('service.name') anymore. Doing so leads to a ServiceNotFoundException.

Unfortunately, this bundle makes use of $container->get() to get LightSAML services. Thus, they need to be either marked public (easy solution) or injected using DI (this is the recommended solution).

Note: this issue affects both SpBundle and SymfonyBridgeBundle 😉

frostieDE added a commit to frostieDE/SymfonyBridgeBundle that referenced this issue May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant