Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Android support for grade 7^ #89

Open
can019 opened this issue Oct 3, 2022 · 6 comments
Open

Android support for grade 7^ #89

can019 opened this issue Oct 3, 2022 · 6 comments

Comments

@can019
Copy link

can019 commented Oct 3, 2022

A build error occurs in Gradle 7.3. There seems to be an error related to maven, so I hope the problem is solved. In particular, among the panarama views supported by react native, this library is considered the only stable. I really hope it's resolved.

@rjsdn0124
Copy link

I have same problem too.......

@BryanJosue98
Copy link

Pls fix this issue :c

@mikson7
Copy link

mikson7 commented May 8, 2023

Did anyone figured out how to fix this issue?

@VahanAper
Copy link

@rodymolenaar could you please find a spare moment to fix this. A lot of people depend on it. Would be really appreciated.

@nadein
Copy link

nadein commented May 22, 2023

I also had an error with maven in build.gradle script (@lightbase/react-native-panorama-view/android/build.gradle).
If was fixed by changing
apply plugin: 'maven'
to
apply plugin: 'maven-publish'

After this change and Gradle sync I faced a new issue with error message:

Configuration with name 'compile' not found.

It is caused by next line:
classpath += files(project.getConfigurations().getByName('compile').asList())
Because compile configuration was deprecated and removed. It's now implementation.

After updating compile -> implementation I ran another sync and got message:

Resolving dependency configuration 'implementation' is not allowed as it is defined as 'canBeResolved=false'.
Instead, a resolvable ('canBeResolved=true') dependency configuration that extends 'implementation' should be resolved.

So I tried to add custom configuration

configurations {
    customConfig.extendsFrom implementation
}

And updated the line
classpath += files(project.getConfigurations().getByName('customConfig').asList())
So it leads to more errors with react-native can't be resolved etc.

So the component needs to be updated to support modern versions of Gradle.
I'm not an expert in Gradle/Android/React Native so it's just a thoughts and suggestions.

Update:
I tried update from this PR: #77
And it fixed all issues. I think it must be approved and merged by maintainers.
@rodymolenaar @cristianocca

@daviseares
Copy link

jcenter is down. So we cant make works on android. :/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants