You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need to update it such that if a channel at any point had an interval exceeding two weeks between updates in either direction (since the client's last seen timestamp), an announcement is also included.
The text was updated successfully, but these errors were encountered:
its kinda awkward, tho, because you have to care even if time A was before the last sync time
so we now need to fetch all updates between (last sync - 2 weeks) and now
because if A was last announced 3 weeks ago before the one yesterday we have to include the announcement for clients that last synced 2 weeks ago
though we do not need to include the announcement for clients that last synced 4 weeks ago
we only need to care, I think, if the "timeout period" spanned the "last sync time"
it's possible that first_update_seen may have happened before last_seen_timestamp, however, the first update seen in the opposite direction happened afterwards. For that case, we'd still need to make sure to also include the channel announcement.
Additionally, by that point, the intermediate update series is no longer available in the delta, so it would need to be calculated in lookup.rs, and a largest_update_interval field would need to be added to the directional update structs.
This is not super high priority, but would be a great project to tackle once #63 lands, which will allow customizing the announcement seen timestamps in tests.
Currently, the announcement inclusion logic lives here:
https://github.com/lightningdevkit/rapid-gossip-sync-server/blob/main/src/serialization.rs#L134
We need to update it such that if a channel at any point had an interval exceeding two weeks between updates in either direction (since the client's last seen timestamp), an announcement is also included.
The text was updated successfully, but these errors were encountered: