Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CheckTX before tx is added into the txPool #189

Open
ggarri opened this issue Jul 1, 2019 · 0 comments
Open

Run CheckTX before tx is added into the txPool #189

ggarri opened this issue Jul 1, 2019 · 0 comments
Labels
enhancement Something that it currently work but can be improved feature New feature, request or improvement

Comments

@ggarri
Copy link
Contributor

ggarri commented Jul 1, 2019

Txs are sent via Ethereum API, if tx passes successfully the tx_pool.validateTx() it is added into the txPool and broadcasted to the local Tendermint node.

Once the local Tendermint node is notified about a new tx this runs abci.checkTx() over the same tx again, doing a double check before broadcasting the tx to other peers in the network. If the tx does not pass the abci.checkTx(), this tx will never be inserted into ethereum stateDB and it will cause an inconsistency in between stateDB and poolTx.
@ggarri ggarri added bug Something isn't working enhancement Something that it currently work but can be improved feature New feature, request or improvement and removed bug Something isn't working labels Jul 1, 2019
ggarri added a commit that referenced this issue Jul 3, 2019
@ggarri
#189 Fetch net peers from consensusApi
3953057
ggarri added a commit that referenced this issue Jul 26, 2019
@ggarri
#189 Upgrade version
62725c6
ggarri added a commit that referenced this issue Jul 26, 2019
@ggarri
#189 Fetch net peers from consensusApi
c529d3c
ggarri added a commit that referenced this issue Jul 26, 2019
@ggarri
#189 Upgrade version
342e06f
ggarri added a commit that referenced this issue Jul 26, 2019
@ggarri
#189 Fetch net peers from consensusApi
1209e6e
ggarri added a commit that referenced this issue Jul 26, 2019
@ggarri
#189 Upgrade version
57da182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Something that it currently work but can be improved feature New feature, request or improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ggarri