Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0][DX] Suggested dependencies and version constraint #466

Open
magnetik opened this issue Nov 6, 2018 · 4 comments
Open

[2.0][DX] Suggested dependencies and version constraint #466

magnetik opened this issue Nov 6, 2018 · 4 comments
Milestone

Comments

@magnetik
Copy link
Contributor

magnetik commented Nov 6, 2018

Some suggested package, such as doctrine-fixtures-bundle requires a specific version to work (for fixtures it's 3.0), but because they are only suggested dependencies, no check are done on the version.

So someone that have the doctrine-fixtures-bundle in 2.0 will see a message doctrine/doctrine-fixtures-bundle must be installed to use this method. (per #437) but nothing related to the version.

Not sure how it can be handled in a clean way.

@Jean85
Copy link
Contributor

Jean85 commented Nov 6, 2018

Does a conflict constraint in the composer.json solve this issue?

@alexislefebvre
Copy link
Collaborator

What about adding adding the minimal version in the exception?

@magnetik
Copy link
Contributor Author

magnetik commented Nov 8, 2018

image

@alexislefebvre
Copy link
Collaborator

Yes we can use both solutions. 🙂

@alexislefebvre alexislefebvre added this to the 2.0 milestone Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants