cleanup: refactor and use bicopy everywhere #2944
Open
+68
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamird
force-pushed
the
remove-bicopy
branch
2 times, most recently
from
4ec7fa0
to
63ae319
Compare
nirs
reviewed
Nov 27, 2024
There was a problem hiding this comment.
This changes the behavior but you did not provide any reason for the change. If the purpose is to remove eliminate a package, just inline the package code in the single user. There is no need to change the code.
If you want to reimplement it and/or change the behavior, please explain why.
Also we have good tests for port_darwin? Before rewriting we should have good tests ensuring that we don't change the behavior by mistake. It should be simple test coping data over unix sockets.
tamird
force-pushed
the
remove-bicopy
branch
2 times, most recently
from
6a612d9
to
c8e7582
Compare
AkihiroSuda
reviewed
Nov 28, 2024
nirs
reviewed
Nov 28, 2024
tamird
force-pushed
the
remove-bicopy
branch
3 times, most recently
from
a2a75a4
to
b92ac24
Compare
tamird
changed the title
There are 3 instances of this pattern and each does this slightly differently. Clean up the implementation to return errors using `errors.Join` (which wasn't available when the original was written) and use it everywhere. This doesn't change behavior because the error return is always just logged (see the only called of `(*pseudoLoopbackForwarder).forward`. Note that the removal of the special handling of `io.EOF` returned from `io.Copy` doesn't change behavior because it can never happen per the latter's documentation. Signed-off-by: Tamir Duberstein <[email protected]>
tamird
force-pushed
the
remove-bicopy
branch
from
b92ac24
to
3d32079
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message.