Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: refactor and use bicopy everywhere #2944

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cleanup: refactor and use bicopy everywhere #2944

wants to merge 1 commit into from
+68 −109

Commits on Nov 28, 2024

  1. cleanup: refactor and use bicopy everywhere 

    There are 3 instances of this pattern and each does this slightly
differently. Clean up the implementation to return errors using
`errors.Join` (which wasn't available when the original was written) and
use it everywhere.

This doesn't change behavior because the error return is always just
logged (see the only called of `(*pseudoLoopbackForwarder).forward`.

Note that the removal of the special handling of `io.EOF` returned from
`io.Copy` doesn't change behavior because it can never happen per the
latter's documentation.

Signed-off-by: Tamir Duberstein <[email protected]>
    @tamird
    tamird committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    3d32079 View commit details
    Browse the repository at this point in the history