Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/goccy/go-yaml from 1.13.6 to 1.15.3 #2949

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 28, 2024

@jandubois: I've added a commit to fix the incompatibilities (yaml.DisallowDuplicateKey no longer exists, and is the default now), and bumped to the latest 1.15.3 release.

I've also adjusted for 2 test failures:

  • load_test needs to match a different upstream error message now
  • validate_test had incorrect YAML that wasn't detected with older versions

Bumps github.com/goccy/go-yaml from 1.13.6 to 1.15.2.

Release notes

Sourced from github.com/goccy/go-yaml's releases.

1.15.2

What's Changed

Full Changelog: goccy/go-yaml@v1.15.1...v1.15.2

1.15.1

What's Changed

Full Changelog: goccy/go-yaml@v1.15.0...v1.15.1

1.15.0

What's Changed

Full Changelog: goccy/go-yaml@v1.14.3...v1.15.0

1.14.3

What's Changed

Full Changelog: goccy/go-yaml@v1.14.2...v1.14.3

1.14.2

What's Changed

Full Changelog: goccy/go-yaml@v1.14.1...v1.14.2

1.14.1

What's Changed

Full Changelog: goccy/go-yaml@v1.14.0...v1.14.1

1.14.0

What's Changed

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/goccy/go-yaml](https://github.com/goccy/go-yaml) from 1.13.6 to 1.15.2.
- [Release notes](https://github.com/goccy/go-yaml/releases)
- [Changelog](https://github.com/goccy/go-yaml/blob/master/CHANGELOG.md)
- [Commits](goccy/go-yaml@v1.13.6...v1.15.2)

---
updated-dependencies:
- dependency-name: github.com/goccy/go-yaml
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Nov 28, 2024
@jandubois jandubois changed the title build(deps): bump github.com/goccy/go-yaml from 1.13.6 to 1.15.2 build(deps): bump github.com/goccy/go-yaml from 1.13.6 to 1.15.3 Nov 28, 2024
@jandubois jandubois marked this pull request as draft November 28, 2024 17:24
@jandubois
Copy link
Member

Turned into a draft because it has 2 test failures (I'll report upstream):

--- FAIL: TestLoadError (0.00s)
    load_test.go:31: assertion failed: expected error to contain "did not find expected key", got "failed to unmarshal YAML (main file \"error.yaml\"): [9:5] value is not allowed in this context. map key-value is pre-defined\n   7 | - mode: system\n       load_test.go:31: assertion failed: expected error to contain "did not find expected key", got "failed to unmarshal YAML (main file \"error.yaml\"): [9:5] value is not allowed in this context. map key-value is pre-defined\n   7 | - mode: system\n   
--- FAIL: TestValidateProbes (0.00s)
    validate_test.go:38: assertion failed: error is not nil: failed to unmarshal YAML (main file "lima.yaml"): [1:27] value is not allowed in this context. map key-value is pre-defined
        >  1 | probes: ["script": "#!foo"]
                                         ^
           2 | images: [{"location": "/"}]

The load_test.go error has a changed error message.

The validate_test.go was using incorrect YAML that wasn't detected before.

Signed-off-by: Jan Dubois <[email protected]>
@jandubois jandubois marked this pull request as ready for review November 28, 2024 21:55
@jandubois
Copy link
Member

Turned into a draft because it has 2 test failures (I'll report upstream):

I've fixed the failures. One was a change in the error message, so I had to adapt the assert. And the other was a bug in out test that wasn't detected before.

Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I added commits to the PR I think it needs another approval from another maintainer.

@jandubois jandubois requested a review from a team November 28, 2024 21:58
@AkihiroSuda AkihiroSuda added this to the v1.0.2 milestone Nov 29, 2024
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jandubois

@AkihiroSuda AkihiroSuda merged commit 122a340 into master Nov 29, 2024
29 checks passed
@jandubois jandubois deleted the dependabot/go_modules/github.com/goccy/go-yaml-1.15.2 branch November 29, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants