Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added group input variable and fixed table #262

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

LauraBoenchenLB
Copy link
Contributor

Closes Ticket #260

Added Input parameter groups to overview_edges() and overview_nodes() to only show specified groups.
Also fixed key word min/max showing for temporal attributes.

Updated tests.

Copy link
Contributor

@MarIniOnz MarIniOnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! cool feature added. Minor changes requested! Also, change the PR name to feat: XXX

medmodels/medrecord/medrecord.py Show resolved Hide resolved
medmodels/medrecord/tests/test_medrecord.py Show resolved Hide resolved
medmodels/medrecord/tests/test_medrecord.py Show resolved Hide resolved
medmodels/medrecord/tests/test_overview.py Show resolved Hide resolved
@LauraBoenchenLB LauraBoenchenLB changed the title added group input variable and fixed table feat: added group input variable and fixed table Nov 29, 2024
@LauraBoenchenLB LauraBoenchenLB force-pushed the 260-group-parameter-for-overview_nodes-and-overview_edges branch from 66637ba to a9ec5fe Compare November 29, 2024 14:41
Copy link
Contributor

@MarIniOnz MarIniOnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very minor comments. Almost there!

@@ -1695,23 +1695,41 @@ def test_describe_group_nodes(self):

medrecord.add_group("Float")
medrecord.add_group(1, nodes=["2", "0"])
medrecord.add_group("Odd", nodes=["1", "3"])
# medrecord.add_group("Odd", nodes=["1", "3"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comments pls

"Ungrouped Nodes": {
"count": 2,
"attribute": {
# "amet": {"type": "Text", "values": "Values: consectetur"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

decimal (int, optional): Decimal point to round the float values to.
Defaults to 2.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erase this extra line!

"""Gets a summary for all edges in groups and their attributes.

Args:
groups (Optional[Union[Group, GroupInputList]], optional): Group or list of
edge groups to display. If no groups are given, all groups containing
nodes are shown. Defaults to None.
decimal (int, optional): Decimal point to round the float values to.
Defaults to 2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The space betwen Returns and Example is two lines, should be 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

group parameter for overview_nodes and overview_edges
2 participants