-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added group input variable and fixed table #262
base: main
Are you sure you want to change the base?
feat: added group input variable and fixed table #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! cool feature added. Minor changes requested! Also, change the PR name to feat: XXX
66637ba
to
a9ec5fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very very minor comments. Almost there!
@@ -1695,23 +1695,41 @@ def test_describe_group_nodes(self): | |||
|
|||
medrecord.add_group("Float") | |||
medrecord.add_group(1, nodes=["2", "0"]) | |||
medrecord.add_group("Odd", nodes=["1", "3"]) | |||
# medrecord.add_group("Odd", nodes=["1", "3"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comments pls
"Ungrouped Nodes": { | ||
"count": 2, | ||
"attribute": { | ||
# "amet": {"type": "Text", "values": "Values: consectetur"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
decimal (int, optional): Decimal point to round the float values to. | ||
Defaults to 2. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Erase this extra line!
"""Gets a summary for all edges in groups and their attributes. | ||
|
||
Args: | ||
groups (Optional[Union[Group, GroupInputList]], optional): Group or list of | ||
edge groups to display. If no groups are given, all groups containing | ||
nodes are shown. Defaults to None. | ||
decimal (int, optional): Decimal point to round the float values to. | ||
Defaults to 2. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The space betwen Returns and Example is two lines, should be 1
Closes Ticket #260
Added Input parameter
groups
tooverview_edges()
andoverview_nodes()
to only show specified groups.Also fixed key word min/max showing for temporal attributes.
Updated tests.