feat: implement python query engine wrapper #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JabobKrauskopf
force-pushed
the
228-rewrite-python-query-engine-wrappers
branch
from
1699b17 to
ec61375
Compare
JabobKrauskopf
force-pushed
the
228-rewrite-python-query-engine-wrappers
branch
from
ec61375 to
497b70f
Compare
JabobKrauskopf
requested review from
OFranke,
FloLimebit,
philippgrosser and
MarIniOnz
MarIniOnz
approved these changes
Oct 11, 2024
JabobKrauskopf
merged commit 76c234e
into
epic/165-query-engine-refactor-1
6 checks passed
LauraBoenchenLB
approved these changes
Oct 11, 2024
| @@ -50,7 +50,7 @@ def __repr__(self) -> str: ... | |||
| def __eq__(self, value: object) -> bool: ... | |||
|
|
|||
| @staticmethod | |||
| def _from_pydatatype(datatype: PyDataType) -> DataType: | |||
| def _from_py_data_type(datatype: PyDataType) -> DataType: | |||
There was a problem hiding this comment.
I honestly prefer the spelling before
| def floor(self) -> None: | ||
| self._single_value_operand.floor() | ||
|
|
||
| def absolute(self) -> None: |
There was a problem hiding this comment.
abs would fit in better with the other functions
| @@ -422,7 +422,7 @@ def __init__( | |||
| ) | |||
|
|
|||
| @classmethod | |||
| def _from_pyschema(cls, schema: PySchema) -> Schema: | |||
| def _from_py_schema(cls, schema: PySchema) -> Schema: | |||
There was a problem hiding this comment.
same here, I kinda see Pyschema as one word, but this opinion is not super strong
JabobKrauskopf
added a commit
that referenced
this pull request
Oct 11, 2024
JabobKrauskopf
added a commit
that referenced
this pull request
Oct 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR concludes the first phase of the query engine refactoring.
All tests should succeed again. Linting and Formatting should also not fail.
There was some functionality removed from the
querying.pyi. This is tracked ind the epic issue #165 underSmall usability improvemets.There are no docstrings and no tests as of now. These will be added in the next phase. This is also tracked in #165