TF-2143 Open composer into a new tab

[dab246]

Issue

#2143

Resolved

Screen.Recording.2024-07-09.at.13.51.38.online-video-cutter.com.mp4

[github-actions]

This PR has been deployed to https://linagora.github.io/tmail-flutter/2896.

[chibenwa]

Looks cool!

Few points:

1/

GIVEN I open composer in TAB A and start input
WHEN chick the openCOmposer in TAB A
THEN the composer is opened into TAB B
AND the composer into TAB A is closed

is this the case?

2/ Suggestion: save a draft before opening into a new tab.

Not that costly I suppose and that way we prevent input loss.

[dab246]

Looks cool!

Few points:

1/

GIVEN I open composer in TAB A and start input WHEN chick the openCOmposer in TAB A THEN the composer is opened into TAB B AND the composer into TAB A is closed

is this the case?

• Currently we do not close composer on Tab A when we do Open new tab on Tab B.
• I don't think we should close composer in Tab A when opening Tab B. It's the same as opening a new tab of an email that we implemented before.
• ANW, if you think it makes sense in terms of UX then we can implement it.

2/ Suggestion: save a draft before opening into a new tab.

Not that costly I suppose and that way we prevent input loss.

I must confirm that the save a draft suggestion gives us the ability to avoid losing data when opening a new tab. But we have to trade off in terms of speed and processing time for this task.

• When performing save a draft, we are forced to call a request to the server. Depending on the server's response time, we will have the results to perform the next steps.
• If a problem occurs during the save a draft process (network error or any server error), we will not be able to continue with the next steps.

[chibenwa]

Then Ok to me with current proposal.
Let's see user feedback then.

[tddang-linagora]

Suggestion:

• Test with rich text

[tddang-linagora]

Suggestion:

• Test input an email to From/CC/BCC, but not choose the suggested pop up yet, and tap open in new tab button

[dab246]

Suggestion:

• Test with rich text

Work well.

Screen.Recording.2024-05-31.at.10.45.03.mov

[dab246]

Suggestion:

• Test input an email to From/CC/BCC, but not choose the suggested pop up yet, and tap open in new tab button

IMO, we should not keep the same text on TextField for To/Cc/Bcc inputs but we should allow automatic tag generation for To/Cc/Bcc inputs when clicking open new tab. It will make storage simpler, still ensuring user data is not lost, although the UX aspect is not very good.

Screen.Recording.2024-05-31.at.11.01.57.mov

[tddang-linagora]

LGTM

[hoangdat]

Build test

• Android
• Web

[tddang-linagora]

Open composer in new tab should not exist on mobile

• @tddang-linagora Test iOS

No-composer-open-in-new-tab-ios.mov

[hoangdat]

@dab246 please don't forget to change destination to master

The base branch was changed.

[dab246]

@dab246 please don't forget to change destination to master

Sorry, my mistake. It depends heavily on the dev branch because it takes the results of the process of changing the send email in composer. So let's wait for the dev branch to merge into master (#2911) and then cherry pick it.

[dab246]

Rebase to the refactor branch is complete