Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fflas-ffpack master does not work with any released version of givaro #327

Open
mkoeppe opened this issue Mar 1, 2021 · 6 comments
Open
Labels

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 1, 2021

checking for GIVARO... yes
checking for GIVARO usability... yes
---------------------------------------
...
In file included from ../../../fflas-ffpack/fflas/fflas_simd/simd128.inl:100:0,
                 from ../../../fflas-ffpack/fflas/fflas_simd.h:227,
                 from ../../../fflas-ffpack/fflas/fflas_freduce.h:30,
                 from ../../../fflas-ffpack/fflas/fflas.h:102,
                 from fflas_L1_inst.C:32:
../../../fflas-ffpack/fflas/fflas_simd/simd128_float.inl:31:10: fatal error: givaro/givtypestring.h: No such file or directory
 #include "givaro/givtypestring.h"
          ^~~~~~~~~~~~~~~~~~~~~~~~

(from https://github.com/mkoeppe/fflas-ffpack/runs/2007184141?check_suite_focus=true)

@cyrilbouvier
Copy link
Member

The file givtypestring.h was added in Givaro after the last release. You need the current master branch of Givaro to compile the current master branch of fflas-ffpack.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 2, 2021

Then the configure check "checking for GIVARO usability" should be updated.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 2, 2021

Also, is there a maintenance branch of fflas-fpack that can be targeted for pull requests if one wants to use a released version of Givaro?

@ClementPernet
Copy link
Member

I fixed the dependency to givaro v4.1.2 and incremented givaro upstream version to 4.1.2alpha.
As for the presence of a maintenance branch, we don't have one, as we keep releasing givaro and fflas-ffpack synchronously.

@ClementPernet
Copy link
Member

Let me mark this issue as wontfix, and close it at the next release of givaro and fflas-ffpack which we are working on.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 11, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants