Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CI + regression tests for conversions #5

Open
satra opened this issue Apr 23, 2024 · 4 comments
Open

add CI + regression tests for conversions #5

satra opened this issue Apr 23, 2024 · 4 comments
Assignees

Comments

@satra
Copy link

satra commented Apr 23, 2024

we should add samples and tests for conversions. it would be good to have some public samples to use in case the linc data remains embargoed. perhaps we could ask each lab for some small samples for testing.

@kabilar
Copy link
Member

kabilar commented Sep 10, 2024

+1 We should make sure that when creating a dataset the metadata match in the OME-Zarr sidecar json file and .zattrs file.

cc @jingjingwu1225

@calvinchai calvinchai self-assigned this Nov 8, 2024
@calvinchai
Copy link
Contributor

We have added this kind of test in the refactored branch. For now, we used some trivial data like black and white images since the real data is too big. It will make the repo size grow rapidly especially if we want to store both input and output. We can definitely added the real data if we found we need it later.

@balbasty
Copy link
Collaborator

Can we close this, or does it need more discussing?

@calvinchai
Copy link
Contributor

I will implement a more throughout test logic using some more real data. We can keep this open before that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants