New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the PotentialSource build functions. #2

Open

maxwest-uw opened this issue Dec 5, 2022 · 0 comments

Labels

good first issue

Collaborator

maxwest-uw commented Dec 5, 2022

Small refactor.
Right now, to create a PotentialSource object, we have to do

ps = koffi.PotentialSource()
ps.build_from_images_and_xy_positions(pixel_positions, mjds)

it would be much nicer if we could do it like this

# call build directy
ps1 = koffi.PotentialSource()
ps1.build(pixel_positions, mjds, format = "xy")

# build from constructor
ps2 = koffi.PotentialSource(pixel_positions, mjds, format="xy")

maxwest-uw added the good first issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment