Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmarks/benchmarks.py has a wrong import statement #330

Closed
hombit opened this issue Dec 11, 2023 · 0 comments · Fixed by #348
Closed

benchmarks/benchmarks.py has a wrong import statement #330

hombit opened this issue Dec 11, 2023 · 0 comments · Fixed by #348
Assignees
@delucchi-cmu
Labels
good first issue Good for newcomers

Comments

@hombit
Copy link
Contributor

hombit commented Dec 11, 2023 •
edited
Loading

I'm not sure if it is intentional, but benchmarks/benchmarks.py's very first Python line is import example_benchmarks, while it should be from {package_name} import example_benchmarks. I've found this issue when making the first commit and pre-commit's pylint failed saying that the module does not exist
@drewoldag drewoldag added the good first issue Good for newcomers label Dec 15, 2023
@delucchi-cmu delucchi-cmu mentioned this issue Dec 22, 2023
Merged
3 tasks
@delucchi-cmu delucchi-cmu self-assigned this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@delucchi-cmu delucchi-cmu

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update benchmarks.py lincc-frameworks/python-project-template
3 participants
@hombit @drewoldag @delucchi-cmu