From 11815615abc2fa7c08139ada93e258b2ff4880a6 Mon Sep 17 00:00:00 2001 From: Ryan Jobse Date: Mon, 18 Mar 2024 16:11:30 -0400 Subject: [PATCH] adding more comments --- core/src/main/scala/kafka/server/Observer.scala | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/core/src/main/scala/kafka/server/Observer.scala b/core/src/main/scala/kafka/server/Observer.scala index 6ca0d0915e630..abc22649c5017 100644 --- a/core/src/main/scala/kafka/server/Observer.scala +++ b/core/src/main/scala/kafka/server/Observer.scala @@ -59,10 +59,11 @@ trait Observer extends Configurable { def observeProduceRequest(requestContext: RequestContext, produceRequest: ProduceRequest): Unit /** - * Hook to track the client library type so different client types can be compared + * Hook to track the client library type so different client types can be compared. This function is in the hot path + * of request-handling so all computations that are added to it need to be light * - * @param isXinfraClient is this clientId a xinfra client - * @param clientId The clientId for this specific request + * @param isXinfraClient is this clientId a xinfra client + * @param clientId The clientId for this specific request */ def trackClientLibrary(isXinfraClient: Boolean, clientId: String): Unit