diff --git a/gradle-plugins/build.gradle b/gradle-plugins/build.gradle index c283626005..d083f53fb8 100644 --- a/gradle-plugins/build.gradle +++ b/gradle-plugins/build.gradle @@ -7,9 +7,14 @@ configurations { } dependencies { + implementation localGroovy() + implementation gradleApi() + testImplementation externalDependency.testng testImplementation externalDependency.junit + integTestImplementation gradleTestKit() + dataTemplateForTesting project(':data') pegasusPluginForTesting project(':data') pegasusPluginForTesting project(':data-avro-generator') @@ -17,31 +22,15 @@ dependencies { pegasusPluginForTesting project(':restli-tools') } +gradlePlugin { + testSourceSets sourceSets.integTest +} + // This is done so that the plugin can know which version of restli should be used when creating the pegasus configuration. processResources { filter(org.apache.tools.ant.filters.ReplaceTokens, tokens: ['version': project.version as String]) } -task resourcesDirWithoutPegasusVersionProperties(type: Sync) { - dependsOn processResources - description 'Creates a backup of the build/gradle-plugins/resources/main/ folder, ' + - 'but excluding pegasus-version.properties. ' + - 'This allows testing the version of pegasus jars in the current build.' - - from(sourceSets.main.output.resourcesDir) { - exclude 'pegasus-version.properties' - } - into "$buildDir/$name" -} - -tasks.pluginUnderTestMetadata { - dependsOn tasks.resourcesDirWithoutPegasusVersionProperties - - // allows us to test plugin application without the unpublished version set in pegasus-version.properties - // also we add the localLibsForTesting to avoid leaking dependencies in published metadata - pluginClasspath.setFrom(files(sourceSets.main.java.outputDir, sourceSets.main.groovy.outputDir, tasks.resourcesDirWithoutPegasusVersionProperties)) -} - integTest { dependsOn configurations.dataTemplateForTesting, configurations.pegasusPluginForTesting systemProperty 'integTest.dataTemplateCompileDependencies', "'${configurations.dataTemplateForTesting.join("', '")}'" diff --git a/gradle-plugins/src/integTest/groovy/com/linkedin/pegasus/gradle/IntegTestingUtil.groovy b/gradle-plugins/src/integTest/groovy/com/linkedin/pegasus/gradle/IntegTestingUtil.groovy new file mode 100644 index 0000000000..bb88184026 --- /dev/null +++ b/gradle-plugins/src/integTest/groovy/com/linkedin/pegasus/gradle/IntegTestingUtil.groovy @@ -0,0 +1,7 @@ +package com.linkedin.pegasus.gradle + +final class IntegTestingUtil { + public static final List ALL_SUPPORTED_GRADLE_VERSIONS = ['6.9.4', '7.0.2', '7.5.1'] + public static final List OLD_PUBLISHING_SUPPORTED_GRADLE_VERSIONS = ['6.9.4'] + public static final List NEW_PUBLISHING_SUPPORTED_GRADLE_VERSIONS = ['6.9.4', '7.0.2', '7.6.3'] +} diff --git a/gradle-plugins/src/integTest/groovy/com/linkedin/pegasus/gradle/PegasusPluginCacheabilityTest.groovy b/gradle-plugins/src/integTest/groovy/com/linkedin/pegasus/gradle/PegasusPluginCacheabilityTest.groovy index 2c4926798e..08167d4d5e 100644 --- a/gradle-plugins/src/integTest/groovy/com/linkedin/pegasus/gradle/PegasusPluginCacheabilityTest.groovy +++ b/gradle-plugins/src/integTest/groovy/com/linkedin/pegasus/gradle/PegasusPluginCacheabilityTest.groovy @@ -19,6 +19,7 @@ class PegasusPluginCacheabilityTest extends Specification { def runner = GradleRunner.create() .withGradleVersion(gradleVersion) .withProjectDir(tempDir.root) + .withEnvironment([PEGASUS_INTEGRATION_TESTING: 'true']) .withPluginClasspath() .withArguments('mainDataTemplateJar') @@ -96,6 +97,6 @@ class PegasusPluginCacheabilityTest extends Specification { preparedSchema.exists() where: - gradleVersion << [ '5.2.1', '5.6.4', '6.9', '7.0.2' ] + gradleVersion << IntegTestingUtil.ALL_SUPPORTED_GRADLE_VERSIONS } } diff --git a/gradle-plugins/src/integTest/groovy/com/linkedin/pegasus/gradle/PegasusPluginIntegrationTest.groovy b/gradle-plugins/src/integTest/groovy/com/linkedin/pegasus/gradle/PegasusPluginIntegrationTest.groovy index bbd1dca7f3..3d5129b4f8 100644 --- a/gradle-plugins/src/integTest/groovy/com/linkedin/pegasus/gradle/PegasusPluginIntegrationTest.groovy +++ b/gradle-plugins/src/integTest/groovy/com/linkedin/pegasus/gradle/PegasusPluginIntegrationTest.groovy @@ -23,6 +23,7 @@ class PegasusPluginIntegrationTest extends Specification { when: def result = GradleRunner.create() + .withEnvironment([PEGASUS_INTEGRATION_TESTING: 'true']) .withGradleVersion(gradleVersion) .withProjectDir(tempDir.root) .withPluginClasspath() @@ -34,7 +35,7 @@ class PegasusPluginIntegrationTest extends Specification { result.task(':mainDataTemplateJar').outcome == SUCCESS where: - gradleVersion << [ '5.2.1', '5.6.4', '6.9', '7.0.2', '7.5.1' ] + gradleVersion << IntegTestingUtil.ALL_SUPPORTED_GRADLE_VERSIONS } @Unroll @@ -84,6 +85,7 @@ class PegasusPluginIntegrationTest extends Specification { when: def result = GradleRunner.create() + .withEnvironment([PEGASUS_INTEGRATION_TESTING: 'true']) .withGradleVersion(gradleVersion) .withProjectDir(tempDir.root) .withPluginClasspath() @@ -102,12 +104,14 @@ class PegasusPluginIntegrationTest extends Specification { assertZipContains(dataTemplateArtifact, 'extensions/com/linkedin/LatLongExtensions.pdl') where: - gradleVersion << [ '5.2.1', '5.6.4', '6.9', '7.0.2', '7.5.1' ] + gradleVersion << IntegTestingUtil.ALL_SUPPORTED_GRADLE_VERSIONS } - def 'mainCopySchema task will remove stale PDSC'() { + @Unroll + def 'mainCopySchema task will remove stale PDSC with Gradle #gradleVersion'() { setup: def runner = GradleRunner.create() + .withEnvironment([PEGASUS_INTEGRATION_TESTING: 'true']) .withProjectDir(tempDir.root) .withPluginClasspath() .withArguments('mainDataTemplateJar') @@ -170,6 +174,9 @@ class PegasusPluginIntegrationTest extends Specification { result.task(':mainCopySchemas').getOutcome() == SUCCESS !preparedPdscFile1.exists() preparedPdscFile2.exists() + + where: + gradleVersion << IntegTestingUtil.ALL_SUPPORTED_GRADLE_VERSIONS } @Unroll @@ -244,6 +251,7 @@ class PegasusPluginIntegrationTest extends Specification { when: def result = GradleRunner.create() + .withEnvironment([PEGASUS_INTEGRATION_TESTING: 'true']) .withGradleVersion(gradleVersion) .withProjectDir(tempDir.root) .withPluginClasspath() @@ -262,7 +270,7 @@ class PegasusPluginIntegrationTest extends Specification { result.task(':impl:compileJava').outcome == SUCCESS where: - gradleVersion << [ '5.2.1', '5.6.4', '6.9', '7.0.2', '7.5.1' ] + gradleVersion << IntegTestingUtil.ALL_SUPPORTED_GRADLE_VERSIONS } private static boolean assertZipContains(File zip, String path) { diff --git a/gradle-plugins/src/integTest/groovy/com/linkedin/pegasus/gradle/publishing/PegasusPluginIvyPublishIntegrationTest.groovy b/gradle-plugins/src/integTest/groovy/com/linkedin/pegasus/gradle/publishing/PegasusPluginIvyPublishIntegrationTest.groovy index 095d6396b6..88a4c5989f 100644 --- a/gradle-plugins/src/integTest/groovy/com/linkedin/pegasus/gradle/publishing/PegasusPluginIvyPublishIntegrationTest.groovy +++ b/gradle-plugins/src/integTest/groovy/com/linkedin/pegasus/gradle/publishing/PegasusPluginIvyPublishIntegrationTest.groovy @@ -16,6 +16,7 @@ package com.linkedin.pegasus.gradle.publishing +import com.linkedin.pegasus.gradle.IntegTestingUtil import org.gradle.testkit.runner.GradleRunner import org.gradle.testkit.runner.TaskOutcome import org.gradle.util.GradleVersion @@ -119,6 +120,7 @@ class PegasusPluginIvyPublishIntegrationTest extends Specification { when: def grandparentRunner = GradleRunner.create() + .withEnvironment([PEGASUS_INTEGRATION_TESTING: 'true']) .withProjectDir(grandparentProject.root) .withGradleVersion(gradleVersion) .withPluginClasspath() @@ -206,6 +208,7 @@ class PegasusPluginIvyPublishIntegrationTest extends Specification { |}'''.stripMargin() def parentRunner = GradleRunner.create() + .withEnvironment([PEGASUS_INTEGRATION_TESTING: 'true']) .withProjectDir(parentProject.root) .withGradleVersion(gradleVersion) .withPluginClasspath() @@ -304,6 +307,7 @@ class PegasusPluginIvyPublishIntegrationTest extends Specification { |}'''.stripMargin() def childRunner = GradleRunner.create() + .withEnvironment([PEGASUS_INTEGRATION_TESTING: 'true']) .withProjectDir(childProject.root) .withGradleVersion(gradleVersion) .withPluginClasspath() @@ -334,30 +338,7 @@ class PegasusPluginIvyPublishIntegrationTest extends Specification { assertZipContains(childProjectDataTemplateArtifact, 'pegasus/com/linkedin/child/Photo.pdl') where: - gradleVersion << [ '6.1', '6.9', '7.0.2', '7.5.1' ] - } - - def 'ivy-publish fails gracefully with Gradle 5.2.1'() { - given: - grandparentProject.newFile('build.gradle') << """ - |plugins { - | id 'ivy-publish' - | id 'pegasus' - |}""".stripMargin() - - when: - def grandparentRunner = GradleRunner.create() - .withProjectDir(grandparentProject.root) - .withGradleVersion('5.2.1') - .withPluginClasspath() - .withArguments('tasks') - //.forwardOutput() - //.withDebug(true) - - def grandparentResult = grandparentRunner.buildAndFail() - - then: - grandparentResult.output.contains 'Using the ivy-publish plugin with the pegasus plugin requires Gradle 6.1 or higher' + gradleVersion << IntegTestingUtil.NEW_PUBLISHING_SUPPORTED_GRADLE_VERSIONS } private static boolean assertZipContains(File zip, String path) { diff --git a/gradle-plugins/src/integTest/groovy/com/linkedin/pegasus/gradle/publishing/PegasusPluginLegacyIvyPublishIntegrationTest.groovy b/gradle-plugins/src/integTest/groovy/com/linkedin/pegasus/gradle/publishing/PegasusPluginLegacyIvyPublishIntegrationTest.groovy index fdfbd8890d..78aec89fbf 100644 --- a/gradle-plugins/src/integTest/groovy/com/linkedin/pegasus/gradle/publishing/PegasusPluginLegacyIvyPublishIntegrationTest.groovy +++ b/gradle-plugins/src/integTest/groovy/com/linkedin/pegasus/gradle/publishing/PegasusPluginLegacyIvyPublishIntegrationTest.groovy @@ -1,10 +1,12 @@ package com.linkedin.pegasus.gradle.publishing +import com.linkedin.pegasus.gradle.IntegTestingUtil import org.gradle.testkit.runner.GradleRunner import org.gradle.testkit.runner.TaskOutcome import org.junit.Rule import org.junit.rules.TemporaryFolder import spock.lang.Specification +import spock.lang.Unroll import java.util.zip.ZipFile @@ -34,7 +36,8 @@ class PegasusPluginLegacyIvyPublishIntegrationTest extends Specification { localIvyRepo = localRepo.newFolder('local-ivy-repo').toURI().toURL() } - def 'publishes and consumes dataTemplate configurations'() { + @Unroll + def 'publishes and consumes dataTemplate configurations with Gradle #gradleVersion'() { given: def gradlePropertiesFile = grandparentProject.newFile('gradle.properties') gradlePropertiesFile << ''' @@ -79,6 +82,8 @@ class PegasusPluginLegacyIvyPublishIntegrationTest extends Specification { when: def grandparentRunner = GradleRunner.create() + .withEnvironment([PEGASUS_INTEGRATION_TESTING: 'true']) + .withGradleVersion(gradleVersion) .withProjectDir(grandparentProject.root) .withPluginClasspath() .withArguments('uploadDataTemplate', 'uploadTestDataTemplate', 'uploadAvroSchema', 'uploadTestAvroSchema', 'uploadArchives', '-is') @@ -155,6 +160,8 @@ class PegasusPluginLegacyIvyPublishIntegrationTest extends Specification { |}'''.stripMargin() def parentRunner = GradleRunner.create() + .withEnvironment([PEGASUS_INTEGRATION_TESTING: 'true']) + .withGradleVersion(gradleVersion) .withProjectDir(parentProject.root) .withPluginClasspath() .withArguments('uploadDataTemplate', 'uploadTestDataTemplate', 'uploadAvroSchema', 'uploadTestAvroSchema', 'uploadArchives', '-is') @@ -235,6 +242,8 @@ class PegasusPluginLegacyIvyPublishIntegrationTest extends Specification { |}'''.stripMargin() def childRunner = GradleRunner.create() + .withEnvironment([PEGASUS_INTEGRATION_TESTING: 'true']) + .withGradleVersion(gradleVersion) .withProjectDir(childProject.root) .withPluginClasspath() .withArguments('uploadDataTemplate', 'uploadTestDataTemplate', 'uploadAvroSchema', 'uploadTestAvroSchema', 'uploadArchives', '-is') @@ -261,6 +270,9 @@ class PegasusPluginLegacyIvyPublishIntegrationTest extends Specification { assertZipContains(childProjectDataTemplateArtifact, 'com/linkedin/child/Photo.class') assertZipContains(childProjectDataTemplateArtifact, 'pegasus/com/linkedin/child/Photo.pdl') + + where: + gradleVersion << IntegTestingUtil.OLD_PUBLISHING_SUPPORTED_GRADLE_VERSIONS } private static boolean assertZipContains(File zip, String path) { diff --git a/gradle-plugins/src/main/java/com/linkedin/pegasus/gradle/PegasusPlugin.java b/gradle-plugins/src/main/java/com/linkedin/pegasus/gradle/PegasusPlugin.java index 39c500f0ab..46e0aa1028 100644 --- a/gradle-plugins/src/main/java/com/linkedin/pegasus/gradle/PegasusPlugin.java +++ b/gradle-plugins/src/main/java/com/linkedin/pegasus/gradle/PegasusPlugin.java @@ -528,8 +528,8 @@ public class PegasusPlugin implements Plugin { public static boolean debug = false; - private static final GradleVersion MIN_REQUIRED_VERSION = GradleVersion.version("1.0"); // Next: 5.2.1 - private static final GradleVersion MIN_SUGGESTED_VERSION = GradleVersion.version("5.2.1"); // Next: 5.3 + private static final GradleVersion MIN_REQUIRED_VERSION = GradleVersion.version("6.9.4"); + private static final GradleVersion MIN_SUGGESTED_VERSION = GradleVersion.version("6.9.4"); // // Constants for generating sourceSet names and corresponding directory names @@ -807,7 +807,7 @@ public void apply(Project project) Properties properties = new Properties(); InputStream inputStream = getClass().getResourceAsStream("/pegasus-version.properties"); - if (inputStream != null) + if (inputStream != null && !"true".equals(System.getenv("PEGASUS_INTEGRATION_TESTING"))) { try { diff --git a/gradle/wrapper/gradle-wrapper.jar b/gradle/wrapper/gradle-wrapper.jar index 87b738cbd0..e708b1c023 100644 Binary files a/gradle/wrapper/gradle-wrapper.jar and b/gradle/wrapper/gradle-wrapper.jar differ diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index 44e7c4d1d7..53b9e3802b 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -1,5 +1,5 @@ distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-5.2.1-bin.zip +distributionUrl=https\://services.gradle.org/distributions/gradle-6.9.4-bin.zip zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists diff --git a/gradlew b/gradlew index af6708ff22..1b6c787337 100755 --- a/gradlew +++ b/gradlew @@ -1,78 +1,129 @@ -#!/usr/bin/env sh +#!/bin/sh + +# +# Copyright © 2015-2021 the original authors. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# https://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# ############################################################################## -## -## Gradle start up script for UN*X -## +# +# Gradle start up script for POSIX generated by Gradle. +# +# Important for running: +# +# (1) You need a POSIX-compliant shell to run this script. If your /bin/sh is +# noncompliant, but you have some other compliant shell such as ksh or +# bash, then to run this script, type that shell name before the whole +# command line, like: +# +# ksh Gradle +# +# Busybox and similar reduced shells will NOT work, because this script +# requires all of these POSIX shell features: +# * functions; +# * expansions «$var», «${var}», «${var:-default}», «${var+SET}», +# «${var#prefix}», «${var%suffix}», and «$( cmd )»; +# * compound commands having a testable exit status, especially «case»; +# * various built-in commands including «command», «set», and «ulimit». +# +# Important for patching: +# +# (2) This script targets any POSIX shell, so it avoids extensions provided +# by Bash, Ksh, etc; in particular arrays are avoided. +# +# The "traditional" practice of packing multiple parameters into a +# space-separated string is a well documented source of bugs and security +# problems, so this is (mostly) avoided, by progressively accumulating +# options in "$@", and eventually passing that to Java. +# +# Where the inherited environment variables (DEFAULT_JVM_OPTS, JAVA_OPTS, +# and GRADLE_OPTS) rely on word-splitting, this is performed explicitly; +# see the in-line comments for details. +# +# There are tweaks for specific operating systems such as AIX, CygWin, +# Darwin, MinGW, and NonStop. +# +# (3) This script is generated from the Groovy template +# https://github.com/gradle/gradle/blob/master/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt +# within the Gradle project. +# +# You can find Gradle at https://github.com/gradle/gradle/. +# ############################################################################## # Attempt to set APP_HOME + # Resolve links: $0 may be a link -PRG="$0" -# Need this for relative symlinks. -while [ -h "$PRG" ] ; do - ls=`ls -ld "$PRG"` - link=`expr "$ls" : '.*-> \(.*\)$'` - if expr "$link" : '/.*' > /dev/null; then - PRG="$link" - else - PRG=`dirname "$PRG"`"/$link" - fi +app_path=$0 + +# Need this for daisy-chained symlinks. +while + APP_HOME=${app_path%"${app_path##*/}"} # leaves a trailing /; empty if no leading path + [ -h "$app_path" ] +do + ls=$( ls -ld "$app_path" ) + link=${ls#*' -> '} + case $link in #( + /*) app_path=$link ;; #( + *) app_path=$APP_HOME$link ;; + esac done -SAVED="`pwd`" -cd "`dirname \"$PRG\"`/" >/dev/null -APP_HOME="`pwd -P`" -cd "$SAVED" >/dev/null + +APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit APP_NAME="Gradle" -APP_BASE_NAME=`basename "$0"` +APP_BASE_NAME=${0##*/} # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. -DEFAULT_JVM_OPTS='"-Xmx64m"' +DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' # Use the maximum available, or set MAX_FD != -1 to use that value. -MAX_FD="maximum" +MAX_FD=maximum warn () { echo "$*" -} +} >&2 die () { echo echo "$*" echo exit 1 -} +} >&2 # OS specific support (must be 'true' or 'false'). cygwin=false msys=false darwin=false nonstop=false -case "`uname`" in - CYGWIN* ) - cygwin=true - ;; - Darwin* ) - darwin=true - ;; - MINGW* ) - msys=true - ;; - NONSTOP* ) - nonstop=true - ;; +case "$( uname )" in #( + CYGWIN* ) cygwin=true ;; #( + Darwin* ) darwin=true ;; #( + MSYS* | MINGW* ) msys=true ;; #( + NONSTOP* ) nonstop=true ;; esac CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar + # Determine the Java command to use to start the JVM. if [ -n "$JAVA_HOME" ] ; then if [ -x "$JAVA_HOME/jre/sh/java" ] ; then # IBM's JDK on AIX uses strange locations for the executables - JAVACMD="$JAVA_HOME/jre/sh/java" + JAVACMD=$JAVA_HOME/jre/sh/java else - JAVACMD="$JAVA_HOME/bin/java" + JAVACMD=$JAVA_HOME/bin/java fi if [ ! -x "$JAVACMD" ] ; then die "ERROR: JAVA_HOME is set to an invalid directory: $JAVA_HOME @@ -81,7 +132,7 @@ Please set the JAVA_HOME variable in your environment to match the location of your Java installation." fi else - JAVACMD="java" + JAVACMD=java which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. Please set the JAVA_HOME variable in your environment to match the @@ -89,84 +140,95 @@ location of your Java installation." fi # Increase the maximum file descriptors if we can. -if [ "$cygwin" = "false" -a "$darwin" = "false" -a "$nonstop" = "false" ] ; then - MAX_FD_LIMIT=`ulimit -H -n` - if [ $? -eq 0 ] ; then - if [ "$MAX_FD" = "maximum" -o "$MAX_FD" = "max" ] ; then - MAX_FD="$MAX_FD_LIMIT" - fi - ulimit -n $MAX_FD - if [ $? -ne 0 ] ; then - warn "Could not set maximum file descriptor limit: $MAX_FD" - fi - else - warn "Could not query maximum file descriptor limit: $MAX_FD_LIMIT" - fi +if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then + case $MAX_FD in #( + max*) + MAX_FD=$( ulimit -H -n ) || + warn "Could not query maximum file descriptor limit" + esac + case $MAX_FD in #( + '' | soft) :;; #( + *) + ulimit -n "$MAX_FD" || + warn "Could not set maximum file descriptor limit to $MAX_FD" + esac fi -# For Darwin, add options to specify how the application appears in the dock -if $darwin; then - GRADLE_OPTS="$GRADLE_OPTS \"-Xdock:name=$APP_NAME\" \"-Xdock:icon=$APP_HOME/media/gradle.icns\"" -fi +# Collect all arguments for the java command, stacking in reverse order: +# * args from the command line +# * the main class name +# * -classpath +# * -D...appname settings +# * --module-path (only if needed) +# * DEFAULT_JVM_OPTS, JAVA_OPTS, and GRADLE_OPTS environment variables. + +# For Cygwin or MSYS, switch paths to Windows format before running java +if "$cygwin" || "$msys" ; then + APP_HOME=$( cygpath --path --mixed "$APP_HOME" ) + CLASSPATH=$( cygpath --path --mixed "$CLASSPATH" ) + + JAVACMD=$( cygpath --unix "$JAVACMD" ) -# For Cygwin, switch paths to Windows format before running java -if $cygwin ; then - APP_HOME=`cygpath --path --mixed "$APP_HOME"` - CLASSPATH=`cygpath --path --mixed "$CLASSPATH"` - JAVACMD=`cygpath --unix "$JAVACMD"` - - # We build the pattern for arguments to be converted via cygpath - ROOTDIRSRAW=`find -L / -maxdepth 1 -mindepth 1 -type d 2>/dev/null` - SEP="" - for dir in $ROOTDIRSRAW ; do - ROOTDIRS="$ROOTDIRS$SEP$dir" - SEP="|" - done - OURCYGPATTERN="(^($ROOTDIRS))" - # Add a user-defined pattern to the cygpath arguments - if [ "$GRADLE_CYGPATTERN" != "" ] ; then - OURCYGPATTERN="$OURCYGPATTERN|($GRADLE_CYGPATTERN)" - fi # Now convert the arguments - kludge to limit ourselves to /bin/sh - i=0 - for arg in "$@" ; do - CHECK=`echo "$arg"|egrep -c "$OURCYGPATTERN" -` - CHECK2=`echo "$arg"|egrep -c "^-"` ### Determine if an option - - if [ $CHECK -ne 0 ] && [ $CHECK2 -eq 0 ] ; then ### Added a condition - eval `echo args$i`=`cygpath --path --ignore --mixed "$arg"` - else - eval `echo args$i`="\"$arg\"" + for arg do + if + case $arg in #( + -*) false ;; # don't mess with options #( + /?*) t=${arg#/} t=/${t%%/*} # looks like a POSIX filepath + [ -e "$t" ] ;; #( + *) false ;; + esac + then + arg=$( cygpath --path --ignore --mixed "$arg" ) fi - i=$((i+1)) + # Roll the args list around exactly as many times as the number of + # args, so each arg winds up back in the position where it started, but + # possibly modified. + # + # NB: a `for` loop captures its iteration list before it begins, so + # changing the positional parameters here affects neither the number of + # iterations, nor the values presented in `arg`. + shift # remove old arg + set -- "$@" "$arg" # push replacement arg done - case $i in - (0) set -- ;; - (1) set -- "$args0" ;; - (2) set -- "$args0" "$args1" ;; - (3) set -- "$args0" "$args1" "$args2" ;; - (4) set -- "$args0" "$args1" "$args2" "$args3" ;; - (5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;; - (6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;; - (7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;; - (8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;; - (9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;; - esac fi -# Escape application args -save () { - for i do printf %s\\n "$i" | sed "s/'/'\\\\''/g;1s/^/'/;\$s/\$/' \\\\/" ; done - echo " " -} -APP_ARGS=$(save "$@") - -# Collect all arguments for the java command, following the shell quoting and substitution rules -eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$APP_BASE_NAME\"" -classpath "\"$CLASSPATH\"" org.gradle.wrapper.GradleWrapperMain "$APP_ARGS" - -# by default we should be in the correct project dir, but when run from Finder on Mac, the cwd is wrong -if [ "$(uname)" = "Darwin" ] && [ "$HOME" = "$PWD" ]; then - cd "$(dirname "$0")" -fi +# Collect all arguments for the java command; +# * $DEFAULT_JVM_OPTS, $JAVA_OPTS, and $GRADLE_OPTS can contain fragments of +# shell script including quotes and variable substitutions, so put them in +# double quotes to make sure that they get re-expanded; and +# * put everything else in single quotes, so that it's not re-expanded. + +set -- \ + "-Dorg.gradle.appname=$APP_BASE_NAME" \ + -classpath "$CLASSPATH" \ + org.gradle.wrapper.GradleWrapperMain \ + "$@" + +# Use "xargs" to parse quoted args. +# +# With -n1 it outputs one arg per line, with the quotes and backslashes removed. +# +# In Bash we could simply go: +# +# readarray ARGS < <( xargs -n1 <<<"$var" ) && +# set -- "${ARGS[@]}" "$@" +# +# but POSIX shell has neither arrays nor command substitution, so instead we +# post-process each arg (as a line of input to sed) to backslash-escape any +# character that might be a shell metacharacter, then use eval to reverse +# that process (while maintaining the separation between arguments), and wrap +# the whole thing up as a single "set" statement. +# +# This will of course break if any of these variables contains a newline or +# an unmatched quote. +# + +eval "set -- $( + printf '%s\n' "$DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS" | + xargs -n1 | + sed ' s~[^-[:alnum:]+,./:=@_]~\\&~g; ' | + tr '\n' ' ' + )" '"$@"' exec "$JAVACMD" "$@" diff --git a/gradlew.bat b/gradlew.bat index 0f8d5937c4..ac1b06f938 100644 --- a/gradlew.bat +++ b/gradlew.bat @@ -1,3 +1,19 @@ +@rem +@rem Copyright 2015 the original author or authors. +@rem +@rem Licensed under the Apache License, Version 2.0 (the "License"); +@rem you may not use this file except in compliance with the License. +@rem You may obtain a copy of the License at +@rem +@rem https://www.apache.org/licenses/LICENSE-2.0 +@rem +@rem Unless required by applicable law or agreed to in writing, software +@rem distributed under the License is distributed on an "AS IS" BASIS, +@rem WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +@rem See the License for the specific language governing permissions and +@rem limitations under the License. +@rem + @if "%DEBUG%" == "" @echo off @rem ########################################################################## @rem @@ -13,15 +29,18 @@ if "%DIRNAME%" == "" set DIRNAME=. set APP_BASE_NAME=%~n0 set APP_HOME=%DIRNAME% +@rem Resolve any "." and ".." in APP_HOME to make it shorter. +for %%i in ("%APP_HOME%") do set APP_HOME=%%~fi + @rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. -set DEFAULT_JVM_OPTS="-Xmx64m" +set DEFAULT_JVM_OPTS="-Xmx64m" "-Xms64m" @rem Find java.exe if defined JAVA_HOME goto findJavaFromJavaHome set JAVA_EXE=java.exe %JAVA_EXE% -version >NUL 2>&1 -if "%ERRORLEVEL%" == "0" goto init +if "%ERRORLEVEL%" == "0" goto execute echo. echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. @@ -35,7 +54,7 @@ goto fail set JAVA_HOME=%JAVA_HOME:"=% set JAVA_EXE=%JAVA_HOME%/bin/java.exe -if exist "%JAVA_EXE%" goto init +if exist "%JAVA_EXE%" goto execute echo. echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME% @@ -45,28 +64,14 @@ echo location of your Java installation. goto fail -:init -@rem Get command-line arguments, handling Windows variants - -if not "%OS%" == "Windows_NT" goto win9xME_args - -:win9xME_args -@rem Slurp the command line arguments. -set CMD_LINE_ARGS= -set _SKIP=2 - -:win9xME_args_slurp -if "x%~1" == "x" goto execute - -set CMD_LINE_ARGS=%* - :execute @rem Setup the command line set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar + @rem Execute Gradle -"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %CMD_LINE_ARGS% +"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %* :end @rem End local scope for the variables with windows NT shell