Issue 76 schema template #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test uses SchemaBuilder to generate a fake schema with only prefixes in it We then use the generic roundtripping mechanism in the test framework to see if we can go Schema->TSV->Schema, retaining the prefixes This uses a simple TSV specification with two columns: - prefix - prefix_reference As expected, this test failed, so we included a fix here. The bug was simply that Prefix was not considered among the list of possible Elements (it's not really an element in the same way Class, Slot, etc are). To fix this we add a condition checking to see if there is a column 'prefix', and if so, if a prefix object is passed, then use the prefix column as the primary ID (i.e prefix_prefix)
cmungall
reviewed
Sep 16, 2022
cmungall
reviewed
Sep 16, 2022
| @@ -172,6 +174,39 @@ def test_enums(): | |||
| _roundtrip(schema, ENUM_SPEC) | |||
|
|
|||
|
|
|||
| def test_prefixes(): | |||
There was a problem hiding this comment.
it looks like your PR is mixing in changes from a previous PR?
There was a problem hiding this comment.
yeah, I treid to build upon your prefixes template fix. does that screw something up?
cmungall
reviewed
Sep 16, 2022
| @@ -215,6 +250,3 @@ def test_export_metamodel_slots(): | |||
| # of this will change | |||
| examples = s['examples'] | |||
| assert 'bibo:draft' == examples | |||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
we need to start with tox for this repo!
There was a problem hiding this comment.
Ok, I watched a video about tox last night, but I don't think I'm ready to make that change yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#76
@cmungall I wrote
test_schema_metadataand addedto
schemasheets/schema_exporter.py, following your #77but I think the exporting steps may have to be different, because we won't be iterating over a multiple schema rows, like we would for slots, classes or prefixes.