Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup of controller owned firewalls #2

Open
hcwagner opened this issue Sep 18, 2024 · 1 comment
Open

cleanup of controller owned firewalls #2

hcwagner opened this issue Sep 18, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@hcwagner
Copy link
Collaborator

Running helm uninstall or rollback will delete the controller and associated manifests from the cluster, but will leave existing firewalls deployed in the cloud infra (Cloud Manager/Linode API).

When deleting the installation of the controller it should check for all CloudFirewalls that are not imported (i.e. owned by something else) and delete them prior to removing the controller.

This will require:

  • finalizer for the controller
  • ownership information to be persisted in the CloudFirewall object state
@hcwagner hcwagner added the enhancement New feature or request label Sep 18, 2024
@hcwagner hcwagner self-assigned this Sep 18, 2024
@hcwagner
Copy link
Collaborator Author

Currently any CloudFirewall CR that is instantiated inside a cluster with the controller installed will be cleaned up when the controller is uninstalled via helm.

Example uninstall command: KUBECONFIG=./my-config.yaml helm delete cloud-firewall-release

This will result in all CRs being cleaned up do to ownership references.

Deleting the cluster via the Linode API or UI will result in dangling Cloud Firewalls existing in the users Linode account. This is due to the deletion of the cluster not issuing a graceful deletion of resources inside the LKE. Future updates may be able to alleviate this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant