[fix] Make tags mutable on LinodeMachine #536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
=======================================
Coverage 64.71% 64.71%
=======================================
Files 79 79
Lines 4237 4237
=======================================
Hits 2742 2742
Misses 1232 1232
Partials 263 263 ☔ View full report in Codecov by Sentry. |
rahulait
force-pushed
the
make-tags-mutable
branch
from
a954ca8
to
bc6ea41
Compare
rahulait
approved these changes
Oct 8, 2024
|
was going to add the ability to specify tags via the |
AshleyDumaine
requested changes
Oct 8, 2024
There was a problem hiding this comment.
If tag updates are to be respected on the Linode API side, we need to update the machine controller to reconcile this update via an UpdateInstance call https://pkg.go.dev/github.com/linode/linodego#Client.UpdateInstance
|
closing this for now - will reopen after testing / re-assessing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Makes tags mutable on linodeMachine
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #524
Special notes for your reviewer:
TODOs: